Carlos,
It is your way of approach where everything what you are doing is in CSS,
but I don't agree that the way where you are setting some styles in the
code is bad one. It's just different approach which is really good in some
cases.
Thanks,
Piotr
2018-04-14 23:02 GMT+02:00 Carlos Rovira <carlosrov...@apache.org>:
> Hi Piotr,
>
> I have already checked Jewel List and ListItemRenderer before sending this
> email.
> Jewel is working, I only say that is carrying some overhead of properties,
> getters and setters and methods that Jewel users will never user at 100%,
> so that's why we want to avoid with PAYG and why we separated more used
> functionality like "disabled" or "passwordinput" for text input, to name
> few examples. In this concrete case, Jewel. will never use that kind of
> methods since all visual estates in the item renderer are defined in CSS.
>
> updateRenderer is ok since I'm overriding it. What's not ok is to have all
> color properties and switch of colors bake into a base item renderer class
> that is buried 3-4 leves down the hierarchy. If it was final level I can
> extend from the parent since normaly it would not be affected by the rest
> of classes and components related.
>
>
>
> 2018-04-14 18:27 GMT+02:00 Piotr Zarzycki <piotrzarzyck...@gmail.com>:
>
> > Hi Carlos,
> >
> > That's why you are creating your own Item renderer and override that
> > method.
> >
> > Although if you can propose other solution. Of course on different branch
> > with checking if you not break anything.
> >
> > Especially MDL Table.
> >
> > Thanks,
> > Piotr
> >
> > On Sat, Apr 14, 2018, 5:34 PM Carlos Rovira <carlosrov...@apache.org>
> > wrote:
> >
> > > Hi,
> > >
> > > this base class
> > >
> > > UIItemRendererBase
> > >
> > > has properties for all colors (hover, selected, and more) and a
> > "useColor"
> > > property, and updateRenderer() method is switching "useColor"
> > >
> > > as a low level class, I think this class should not have all this info,
> > > since most people will never use.
> > >
> > > In Basic I think is possible, but in Jewel colors, shapes and effects
> > comer
> > > from CSS.
> > >
> > > In this case I think 95% of users will never go that way of setting
> > colors
> > > when the can do simply this:
> > >
> > > .jewel.item {
> > > cursor: pointer;
> > > padding: 8px;
> > > flex-shrink: 0;
> > > flex-grow: 1;
> > > }
> > > .jewel.item:hover {
> > > color: #FFFFFF;
> > > background: #24a3ef;
> > > }
> > > .jewel.item:active, .jewel.item.selected {
> > > color: #FFFFFF;
> > > background: #0f88d1;
> > > }
> > >
> > > without wiring a single line between logic and css.
> > >
> > > So I think useColors, and colors should be refactored to a bead or
> > > something that will not compromise the high level UI sets that will
> never
> > > use this kind of properties.
> > >
> > > Although I'm creating a ItemRenderer from scratch, my problem here's
> that
> > > there's so much hierarchy here and many other classes in the tree that
> > > depends.
> > >
> > > Creating a class extending "leaf" class nodes are easy, but when
> problems
> > > arise in the middle of the hierarchy chain, we have a problem that is
> > > difficult to solve
> > >
> > > thanks
> > >
> > >
> > >
> > > --
> > > Carlos Rovira
> > > http://about.me/carlosrovira
> > >
> >
>
>
>
> --
> Carlos Rovira
> http://about.me/carlosrovira
>
--
Piotr Zarzycki
Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*
