Out of curiosity, why are there no type defs for raw mdl components?
________________________________ From: Alex Harui <[email protected]> Sent: Monday, June 18, 2018 6:53:51 AM To: [email protected]; [email protected] Subject: Re: [royale-asjs] branch feature/revert-refactor updated: Fixes #261. Untyped members need to be surrounded with quotes. FYI, IMO, the recommended practice is to not have untyped members and create types if needed. But this is for MDL, so doesn't really matter. My reasoning is that it will always help future optimizers and runtimes to know the types of everything. My 2 cents, -Alex On 6/17/18, 3:43 AM, "[email protected]" <[email protected]> wrote: This is an automated email from the ASF dual-hosted git repository. yishayw pushed a commit to branch feature/revert-refactor in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7Cd77275bd67964759a70908d5d43f1b91%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C1%7C636648289868136910&sdata=OX9Bv6x8tofEiFP4CL618YzO8flAxbThhkdk13pZ3RQ%3D&reserved=0 The following commit(s) were added to refs/heads/feature/revert-refactor by this push: new c1f20f3 Fixes #261. Untyped members need to be surrounded with quotes. c1f20f3 is described below commit c1f20f30eeddf4aec20894f5326ec1d188b729c0 Author: DESKTOP-RH4S838\Yishay <[email protected]> AuthorDate: Sun Jun 17 13:42:50 2018 +0300 Fixes #261. Untyped members need to be surrounded with quotes. --- .../src/main/royale/org/apache/royale/mdl/ProgressBar.as | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/ProgressBar.as b/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/ProgressBar.as index 8dbaa23..820a9f5 100644 --- a/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/ProgressBar.as +++ b/frameworks/projects/MaterialDesignLite/src/main/royale/org/apache/royale/mdl/ProgressBar.as @@ -149,7 +149,7 @@ package org.apache.royale.mdl { if (materialProgress && !_indeterminate) { - materialProgress.setProgress(value); + materialProgress["setProgress"](value); } } @@ -171,7 +171,7 @@ package org.apache.royale.mdl { if (!event.currentTarget) return; - materialProgress = event.currentTarget.MaterialProgress; + materialProgress = event.currentTarget["MaterialProgress"]; setCurrentProgress(_currentProgress); setCurrentBuffer(_currentBuffer); -- To stop receiving notification emails like this one, please contact [email protected].
