Already created a branch (moment).


________________________________
From: Piotr Zarzycki <piotrzarzyck...@gmail.com>
Sent: Monday, September 17, 2018 12:07:05 PM
To: dev@royale.apache.org
Subject: Re: TypeDefs for Moment.js

Hi Yishay,

Please make that stuff on a branch feature/momentjs_typedefs. I'm trying to
prepare release so don't want to have more new stuff in develop.

Thanks,
Piotr

pon., 17 wrz 2018 o 10:24 Yishay Weiss <yishayj...@hotmail.com> napisał(a):

> Hi,
>
> I’m struggling trying create a typedefs for moment.js [1].  There’s no
> ready externs file as far as I can tell so I tried using TypeScript
> definition file [2] in conjunction with this conversion utility [3].
>
> Unfortunately, there are overloaded methods which seem to confuse the
> conversion utility and create duplicate arguments in signatures  (e.g.
> weekdays – line 1196 [4]).
>
> Any ideas?
>
> [1] https://momentjs.com/
> [2] https://github.com/moment/moment/blob/develop/moment.d.ts
> [3] https://github.com/eredo/tsd2cce
> [4]
> https://github.com/royale-extras/closure-compiler/blob/master/contrib/externs/moment.js
>


--

Piotr Zarzycki

Patreon: *https://www.patreon.com/piotrzarzycki
<https://www.patreon.com/piotrzarzycki>*

Reply via email to