I see some discussions about messages not getting through on the list today, so I can't be sure the last one or this one got through. I pushed the commit, but please revert if if you don't want it in the release yet. thanks, Greg
On Fri, Nov 9, 2018 at 3:48 PM Greg Dove <[email protected]> wrote: > Hi Alex, > > I checked and only now realized that you made the change in Language.as > quite recently to add support for actionscript Array.sort method signature > variations to javascript - I looked in Language.as and saw the support for > it but did not check when it was added until just now - last month! I hope > I did not double up on the compler side which you may have already begun as > well... I have a fix ready for the 2 method signatures that need to use > that Language.sort call with the options argument, and new tests in > compiler-jx for that. > As I suspect you are aware, currently it gives wrong, but errorless, code > in some places, like mx.colllections.Sort, so I am keen to get this in. > > Does anything else need doing for typedefs - do I need to update an > existing method signature, and if so, how? (I didn't do anything in > typedefs so far) > > ...if so, I *think* it just needs the optional options arg... > > If the typedefs change can wait, or is not needed, please let me know and > I will push this fix asap, otherwise please point me in the direction of > what I need to do for typedefs. > > thanks, > Greg > > > > > > >
