Hi,
just catching here.
@Harbs <ha...@in-tools.com> the problem in TourDeJewel example is shown by
running this app and all labels in menus (in the left drawer navigation
menu) and also some buttons are empty?
What I found, and don't know if is something related to this or not, is
that recompiling TourDeJewel (or out current real App) fails 1 time of
about 15 compilations with empty labels in menus and buttons.
So this seems to me something that I had to report, but don't know how to
show a test case. This seems to me something related maybe a thread issue
in java compiler or something like that.
Thanks
Carlos
El mié., 19 dic. 2018 a las 9:18, Harbs (<harbs.li...@gmail.com>) escribió:
> The DataBindingExample doesn’t seem to have an obvious runtime error, but
> there are missing requires in DataBindingExample.js and the addDependencies
> are different.
>
> HTH,
> Harbs
>
> > On Dec 19, 2018, at 10:12 AM, Harbs <harbs.li...@gmail.com> wrote:
> >
> > The TourDeJewel example has the problem.
> >
> > Rebuilding the debug version gets the runtime error that ApplicationBase
> is undefined.
> >
> > Rebuilding the release build results in 238 errors in the Closure
> Compiler.
> >
> >> On Dec 19, 2018, at 10:01 AM, Alex Harui <aha...@adobe.com.INVALID>
> wrote:
> >>
> >> The circular dependency issue is almost certain to affect
> GoogDepsWriter. It is end of my day here so I will start on those changes
> tomorrow. So if you can find a simple test case for your issue (it doesn't
> have to fail in the browser, it might be good enough that the addDependency
> List is different or missing some items) then I will look at that test case
> after I finish up the circular issue.
> >>
> >> Thanks,
> >> -Alex
> >>
> >> On 12/18/18, 11:25 PM, "Alex Harui" <aha...@adobe.com.INVALID> wrote:
> >>
> >> Pretty sure something will need to change in GoogDepsWriter. Don't
> know what just yet. Might be best if you can come up with a simple test
> case.. I'm working on a circular dependency issue right now that might
> also affect GoogDepsWriter. If you build some of our examples, do any show
> missing goog.addDependencies?
> >>
> >> -Alex
> >>
> >> On 12/18/18, 11:12 PM, "Harbs" <harbs.li...@gmail.com> wrote:
> >>
> >> So where do you suggest we fix it? In
> GoogDepsWriter.removeRequires?
> >>
> >> I’m not completely following what’s going on there.
> >>
> >> Harbs
> >>
> >>> On Dec 19, 2018, at 12:52 AM, Alex Harui <aha...@adobe.com.INVALID>
> wrote:
> >>>
> >>> Yeah, that makes more sense. So somehow the information we get back
> from processing the Royale Dependency List isn't recovering all of the
> dependency data. I had noticed that we didn't list @extends and
> @implements in the Dependency Lists and wondered how that was working.
> Maybe it isn't working and we've been getting lucky where we've seen it
> work.
> >>>
> >>> -Alex
> >>>
> >>> On 12/18/18, 1:59 PM, "Harbs" <harbs.li...@gmail.com> wrote:
> >>>
> >>> The working one has (in this order):
> >>> goog.addDependency('../../../org/apache/royale/core/Application.js',
> ['org.apache.royale.core.Application'],
> ['org.apache.royale.core.ApplicationBase',
> 'org.apache.royale.core.IStrand', 'org.apache.royale.core.IParent',
> 'org.apache.royale.events.IEventDispatcher',
> 'org.apache.royale.core.IInitialViewApplication',
> 'org.apache.royale.core.IPopUpHost',
> 'org.apache.royale.core.IPopUpHostParent',
> 'org.apache.royale.core.IRenderedObject']);
> >>>
> goog.addDependency('../../../org/apache/royale/core/IInitialViewApplication.js',
> ['org.apache.royale.core.IInitialViewApplication'],
> ['org.apache.royale.events.IEventDispatcher']);
> >>> goog.addDependency('../../../org/apache/royale/core/IPopUpHost.js',
> ['org.apache.royale.core.IPopUpHost'], []);
> >>>
> goog.addDependency('../../../org/apache/royale/core/IPopUpHostParent.js',
> ['org.apache.royale.core.IPopUpHostParent'],
> ['org.apache.royale.core.IParent']);
> >>>
> goog.addDependency('../../../org/apache/royale/core/ApplicationBase.js',
> ['org.apache.royale.core.ApplicationBase'],
> ['org.apache.royale.core.HTMLElementWrapper',
> 'org.apache.royale.core.IFlexInfo']);
> >>> goog.addDependency('../../../org/apache/royale/core/IFlexInfo.js',
> ['org.apache.royale.core.IFlexInfo'], []);
> >>>
> >>> The broken one has:
> >>>
> >>> goog.addDependency('../../../org/apache/royale/core/Application.js',
> ['org.apache.royale.core.Application'],
> ['org.apache.royale.core.ApplicationBase',
> 'org.apache.royale.core.IStrand', 'org.apache.royale.core.IParent',
> 'org.apache.royale.events.IEventDispatcher',
> 'org.apache.royale.core.IInitialViewApplication',
> 'org.apache.royale.core.IPopUpHost',
> 'org.apache.royale.core.IPopUpHostParent',
> 'org.apache.royale.core.IRenderedObject']);
> >>>
> goog.addDependency('../../../org/apache/royale/core/BrowserResizeListener.js',
> ['org.apache.royale.core.BrowserResizeListener'],
> ['org.apache.royale.core.IBead']);
> >>>
> goog.addDependency('../../../org/apache/royale/core/CallLaterBead.js',
> ['org.apache.royale.core.CallLaterBead'], ['org.apache.royale.core.IBead']);
> >>>
> >>> (No addDependency for ApplicationBase)
> >>>
> >>> The broken one also has no addDependency for HTMLElementWrapper,
> IFlexInfo and I’m sure many others.
> >>>
> >>>> On Dec 18, 2018, at 11:43 PM, Alex Harui <aha...@adobe.com.INVALID>
> wrote:
> >>>>
> >>>> Is there a goog.addDependency for ApplicationBase.js in the working
> and non-working index.html, and are they different?
> >>>
> >>>
> >>>
> >>
> >>
> >>
> >>
> >>
> >
>
>
--
Carlos Rovira
http://about.me/carlosrovira
