ok Harbs, thanks, I'll try it soon El jue., 27 dic. 2018 a las 12:06, Harbs (<harbs.li...@gmail.com>) escribió:
> Alex already changed this. > > > On Dec 27, 2018, at 12:20 PM, Carlos Rovira <carlosrov...@apache.org> > wrote: > > > > Hi, I finding that this commit is making Maven unable to pass. Reverting > in > > local make build pass. > > @Yishay Weiss <yishayj...@hotmail.com> for what I read this can be > > reverted, right? I'll wait to your answer > > > > thanks > > > > El jue., 27 dic. 2018 a las 8:01, Yishay Weiss (<yishayj...@hotmail.com > >) > > escribió: > > > >> Sounds good, feel free to revert. > >> > >> > >> > >> ________________________________ > >> From: Alex Harui <aha...@adobe.com.INVALID> > >> Sent: Thursday, December 27, 2018 3:43:45 AM > >> To: dev@royale.apache.org; comm...@royale.apache.org > >> Subject: Re: [royale-asjs] branch develop updated: Fix implicit coercion > >> error > >> > >> I don't think we should hack it like this. Casting a plain object to a > >> type makes the code look strange, and it might not minify correctly. I > >> have a different fix I hope to put in shortly where we actually pass in > an > >> instance of the BlogPropertyBag. > >> > >> -Alex > >> > >> On 12/26/18, 6:57 AM, "yish...@apache.org" <yish...@apache.org> wrote: > >> > >> This is an automated email from the ASF dual-hosted git repository. > >> > >> yishayw pushed a commit to branch develop > >> in repository > >> > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&data=02%7C01%7Caharui%40adobe.com%7Cf49498642ee3461f0c5408d66b427f89%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636814330700634536&sdata=YiAM%2FJCbAfsj%2Fbi2sH9ggzN4JSwpdfelXbGM76SF5x0%3D&reserved=0 > >> > >> > >> The following commit(s) were added to refs/heads/develop by this > push: > >> new 2f127d4 Fix implicit coercion error > >> 2f127d4 is described below > >> > >> commit 2f127d459ee807f197950e11af947c623c270369 > >> Author: DESKTOP-RH4S838\Yishay <yishayj...@hotmail.com> > >> AuthorDate: Wed Dec 26 16:57:33 2018 +0200 > >> > >> Fix implicit coercion error > >> --- > >> > >> .../src/main/royale/org/apache/royale/storage/file/DataOutputStream.as > | > >> 2 +- > >> > >> .../apache/royale/storage/providers/AndroidExternalStorageProvider.as > | > >> 2 +- > >> .../royale/org/apache/royale/storage/providers/WebStorageProvider.as > >> | 2 +- > >> 3 files changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git > >> > a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as > >> > b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as > >> index cff76eb..55eab71 100644 > >> --- > >> > a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as > >> +++ > >> > b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/file/DataOutputStream.as > >> @@ -117,7 +117,7 @@ public class DataOutputStream extends > >> EventDispatcher implements IDataOutput > >> public function writeText(text:String):void > >> { > >> COMPILE::JS { > >> - var blob:Blob = new Blob([text], { type: > >> 'text/plain' }); > >> + var blob:Blob = new Blob([text], { type: > >> 'text/plain' } as BlobPropertyBag); > >> _fileWriter.write(blob); > >> } > >> COMPILE::SWF { > >> diff --git > >> > a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as > >> > b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as > >> index ea79a5b..cf05a73 100644 > >> --- > >> > a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as > >> +++ > >> > b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/AndroidExternalStorageProvider.as > >> @@ -199,7 +199,7 @@ package org.apache.royale.storage.providers > >> > >> _target.dispatchEvent(newEvent); > >> }; > >> > >> - var blob:Blob = > >> new Blob([text], { type: 'text/plain' }); > >> + var blob:Blob = > >> new Blob([text], { type: 'text/plain' } as BlobPropertyBag); > >> > >> fileWriter.write(blob); > >> }, function(e):void { > >> var > >> errEvent:FileErrorEvent = new FileErrorEvent("ERROR"); > >> diff --git > >> > a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/WebStorageProvider.as > >> > b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/WebStorageProvider.as > >> index 1632bfa..dd9c84c 100644 > >> --- > >> > a/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/WebStorageProvider.as > >> +++ > >> > b/frameworks/projects/Storage/src/main/royale/org/apache/royale/storage/providers/WebStorageProvider.as > >> @@ -199,7 +199,7 @@ package org.apache.royale.storage.providers > >> > >> _target.dispatchEvent(newEvent); > >> }; > >> > >> - var blob:Blob = > >> new Blob([text], { type: 'text/plain' }); > >> + var blob:Blob = > >> new Blob([text], { type: 'text/plain' } as BlobPropertyBag); > >> > >> fileWriter.write(blob); > >> }, function(e):void { > >> var > >> errEvent:FileErrorEvent = new FileErrorEvent("ERROR"); > >> > >> > >> > >> > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > -- Carlos Rovira http://about.me/carlosrovira
