I changed popup and validator.

The validator behavior is a bit different, but I think it’s better.

DateValidator still needs work.

Let me know what you think.

Harbs

> On Jan 15, 2019, at 5:19 PM, Harbs <[email protected]> wrote:
> 
> I don’t think Popup should implement IPopupHost and IPopupHostParent.
> 
> Also: Tips including ErrorTips should self-remove as soon as the component 
> which launches them loses focus.
> 
>> On Jan 15, 2019, at 2:06 PM, Carlos Rovira <[email protected]> wrote:
>> 
>> Hi Harbs
>> 
>> I saw this the other day. Thanks for reporting.
>> 
>> The problem is that PopUp uses
>> 
>> UIUtils.addPopUp(_popUp, getHost());
>> (that does a call to findPopUpHost)
>> 
>> And the ToolTips uses this too.
>> 
>> In the other hand Alex did some changes and now we have
>> 
>> IPopUpHost
>> 
>> and
>> 
>> IPopUpHostParent
>> 
>> And I think Jewel and maybe Basic too is not having into account this kind
>> of cases where a something popups other things and the latest popup another.
>> 
>> I think this is a good place to solve this. So could you help with this
>> issue and try to fix it? Since you already has experience with popups hope
>> you could bring a proper solution to this.
>> I already tried with no luck.
>> 
>> About adding to the body...is not a problem, if we need to add there, I
>> think is ok. So if the change implies that I think we could do it.
>> 
>> Maybe we could have some issues with CSS rules of that components, but I'm
>> sure I can help in that part.
>> 
>> Let me know if you can
>> 
>> thanks
>> 
>> Carlos
>> 
>> 
>> 
>> El mar., 15 ene. 2019 a las 9:21, Harbs (<[email protected]>) escribió:
>> 
>>> https://royale.apache.org/tourdejewel/#
>>> 
>>> Click on Popup and click the non-modal one.
>>> 
>>> Type something into the fields and you’ll see that the validation text
>>> gets cut off to the boundaries of the section div on the main page. The
>>> validation div also remains after closing the popup.
>>> 
>>> Is there a reason Jewel popups are not added to the body?
>>> 
>>> Thanks,
>>> Harbs
>> 
>> 
>> 
>> -- 
>> Carlos Rovira
>> http://about.me/carlosrovira
> 

Reply via email to