Would it make sense to change the signature to
public function split(separator:*=undefined,limit:int=0):Array
?
________________________________
From: Harbs <harbs.li...@gmail.com>
Sent: Sunday, February 10, 2019 1:08:14 PM
To: dev@royale.apache.org
Subject: Re: Breaking Compiler Change
Found it in XML:
public function
split(separator:*=undefined,limit:*=undefined):Array
{
return s().split(separator,limit);
}
Becomes:
XML.prototype.split = function(separator, limit) {
separator = typeof separator !== 'undefined' ? separator : undefined;
limit = typeof limit !== 'undefined' ? limit : undefined;
return this.XML_s().split(separator, Number(limit));
};
Number(limit) (i.e. Number(undefined) is becoming NaN.
Harbs
> On Feb 10, 2019, at 11:00 AM, Harbs <harbs.li...@gmail.com> wrote:
>
> The problem appears to be fd7b81f4448db0f5eb70f22208c9144549cc4806
>
> I’m still trying to track down exactly where it’s breaking…
>
>> On Feb 10, 2019, at 12:11 AM, Harbs <harbs.li...@gmail.com> wrote:
>>
>> Nope. It’s not ad2e39d4e1ea129cd10557b877b5ae80a12928e6
>>
>> I’ll try to track it down tomorrow…
>>
>>> On Feb 9, 2019, at 11:54 PM, Harbs <harbs.li...@gmail.com> wrote:
>>>
>>> FYI: One of the compiler change in the last few days broke my app.
>>>
>>> I’m not yet positive which commit it is, but I think it’s
>>> ad2e39d4e1ea129cd10557b877b5ae80a12928e6
>>>
>>> My app works with
>>> 87ed9852674f0148f8ed0da659714172979e48d1
>>>
>>> I’ll post more observations tomorrow…
>>>
>>> Harbs
>>
>
