I have confirmed that my latest compiler commit fixes TourDeJewel. Sorry for the trouble!
- Josh On 2019/03/20 19:51:27, Carlos Rovira <carlosrov...@apache.org> wrote: > Thanks Josh, > > I was looking to your commits and since all is code and there's no config > things, I was confused and not understanding how the fail could be happening > Now this seems to explain the issue > thanks for getting to the problem > > Carlos > > > El mié., 20 mar. 2019 a las 20:48, Josh Tynjala (<joshtynj...@apache.org>) > escribió: > > > I've determined that hoisting is having trouble with chained variables, > > like these: > > > > var bead:IBead, i:uint, n:uint; > > > > Working on a fix. > > > > (I was seeing different behavior with a nightly build vs Maven because the > > framework in the nightly was built before my hoisting changes) > > > > - Josh > > > > On 2019/03/20 17:53:08, Josh Tynjala <joshtynj...@apache.org> wrote: > > > No, I built with VSCode, which uses the regular command line compiler > > from the SDK. > > > > > > I updated/installed all repos and built TourDeJewel with Maven. I can > > now see the errors that you describe. It seems that Maven executes the > > compiler differently somehow. This could be tricky to debug. > > > > > > - Josh > > > > > > On 2019/03/20 17:38:09, Carlos Rovira <carlosrov...@apache.org> wrote: > > > > Hi Josh, > > > > > > > > that's very strange since a mate working with me found the same > > problem as > > > > me... he is on windows while I'm on mac, and he found as me the same > > > > problem doing in his laptop the same as me: we both run a script that > > > > updates from git, then pass maven in three repos and then construct > > SDK. > > > > > > > > Are you building TDJ with maven? > > > > > > > > thanks > > > > > > > > Carlos > > > > > > > > > > > > El mié., 20 mar. 2019 a las 16:51, Josh Tynjala (< > > joshtynj...@apache.org>) > > > > escribió: > > > > > > > > > In my initial tests, I am unable to reproduce this issue. I > > overlayed the > > > > > latest compiler changes onto the latest nightly build, and a clean > > compile > > > > > of TourDeJewel is running correctly in Chrome. I tried with > > > > > js-default-initializers set to both true and false. > > > > > > > > > > Now, I am running `ant binary-release` to create a full SDK from > > scratch > > > > > (which will take a while), but I don't expect that to make a > > difference. > > > > > > > > > > - Josh > > > > > > > > > > On 2019/03/20 15:27:42, Carlos Rovira <carlosrov...@apache.org> > > wrote: > > > > > > Thank Josh! :) > > > > > > > > > > > > El mié., 20 mar. 2019 a las 15:14, Josh Tynjala (< > > joshtynj...@apache.org > > > > > >) > > > > > > escribió: > > > > > > > > > > > > > I'm looking into it! > > > > > > > > > > > > > > - Josh > > > > > > > > > > > > > > On 2019/03/20 08:42:43, Carlos Rovira <carlosrov...@apache.org> > > wrote: > > > > > > > > Hi, I can confirm that the problem is in the latest three > > commits in > > > > > > > > royale-compiler repo. > > > > > > > > @Josh Tynjala <joshtynj...@gmail.com> , hope you can take a > > look. Is > > > > > > > easy > > > > > > > > to check testing with Tour De Jewel app > > > > > > > > > > > > > > > > thanks in advance > > > > > > > > > > > > > > > > Carlos > > > > > > > > > > > > > > > > > > > > > > > > El mié., 20 mar. 2019 a las 9:10, Carlos Rovira (< > > > > > > > carlosrov...@apache.org>) > > > > > > > > escribió: > > > > > > > > > > > > > > > > > Hi > > > > > > > > > > > > > > > > > > I'm getting black page with Tour de Jewel when compile > > against > > > > > latest > > > > > > > > > changes of yesterday > > > > > > > > > I'm trying to get where is the problem. Here's the browser > > fails: > > > > > > > > > > > > > > > > > > Uncaught SyntaxError: Unexpected token if > > > > > > > > > base.js:2485 Uncaught TypeError: Cannot read property > > 'prototype' > > > > > of > > > > > > > > > undefined > > > > > > > > > at Object.goog.inherits (base.js:2485) > > > > > > > > > at UIBase.js:46 > > > > > > > > > goog.inherits @ base.js:2485 > > > > > > > > > (anonymous) @ UIBase.js:46 > > > > > > > > > base.js:2485 Uncaught TypeError: Cannot read property > > 'prototype' > > > > > of > > > > > > > > > undefined > > > > > > > > > at Object.goog.inherits (base.js:2485) > > > > > > > > > at ApplicationBase.js:32 > > > > > > > > > goog.inherits @ base.js:2485 > > > > > > > > > (anonymous) @ ApplicationBase.js:32 > > > > > > > > > ElementWrapper.js:118 Uncaught SyntaxError: Unexpected token > > if > > > > > > > > > base.js:2485 Uncaught TypeError: Cannot read property > > 'prototype' > > > > > of > > > > > > > > > undefined > > > > > > > > > at Object.goog.inherits (base.js:2485) > > > > > > > > > at HTTPServiceBase.js:24 > > > > > > > > > goog.inherits @ base.js:2485 > > > > > > > > > (anonymous) @ HTTPServiceBase.js:24 > > > > > > > > > KeyboardEvent.js:308 Uncaught TypeError: Cannot read property > > > > > > > > > 'converterMap' of undefined > > > > > > > > > at > > > > > Function.org.apache.royale.events.KeyboardEvent.setupConverter > > > > > > > > > (KeyboardEvent.js:308) > > > > > > > > > at KeyboardEvent.js:487 > > > > > > > > > org.apache.royale.events.KeyboardEvent.setupConverter @ > > > > > > > > > KeyboardEvent.js:308 > > > > > > > > > (anonymous) @ KeyboardEvent.js:487 > > > > > > > > > MouseEvent.js:506 Uncaught TypeError: Cannot read property > > > > > > > 'converterMap' > > > > > > > > > of undefined > > > > > > > > > at > > Function.org.apache.royale.events.MouseEvent.setupConverter > > > > > > > > > (MouseEvent.js:506) > > > > > > > > > at MouseEvent.js:812 > > > > > > > > > org.apache.royale.events.MouseEvent.setupConverter @ > > > > > MouseEvent.js:506 > > > > > > > > > (anonymous) @ MouseEvent.js:812 > > > > > > > > > ApplicationBase.js:30 Uncaught TypeError: > > > > > > > > > org.apache.royale.core.ApplicationBase.base is not a function > > > > > > > > > at App.org.apache.royale.core.ApplicationBase > > > > > > > (ApplicationBase.js:30) > > > > > > > > > at Function.childCtor.base (base.js:2515) > > > > > > > > > at App.org.apache.royale.jewel.Application [as > > constructor] > > > > > > > > > (Application.js:42) > > > > > > > > > at Function.childCtor.base (base.js:2515) > > > > > > > > > at new App (App.js:395) > > > > > > > > > at index.html:505 > > > > > > > > > org.apache.royale.core.ApplicationBase @ > > ApplicationBase.js:30 > > > > > > > > > childCtor.base @ base.js:2515 > > > > > > > > > org.apache.royale.jewel.Application @ Application.js:42 > > > > > > > > > childCtor.base @ base.js:2515 > > > > > > > > > App @ App.js:395 > > > > > > > > > (anonymous) @ index.html:505 > > > > > > > > > > > > > > > > > > -- > > > > > > > > > Carlos Rovira > > > > > > > > > http://about.me/carlosrovira > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > Carlos Rovira > > > > > > > > http://about.me/carlosrovira > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Carlos Rovira > > > > > > http://about.me/carlosrovira > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Carlos Rovira > > > > http://about.me/carlosrovira > > > > > > > > > > > > -- > Carlos Rovira > http://about.me/carlosrovira >
