url.js is part of the standard externs in the closure compiler repo. We only need to download the ones from royale-extras for files that are modified from the google one.
> On Jul 9, 2019, at 2:39 PM, Piotr Zarzycki <[email protected]> wrote: > > I thought this is the right place, from where I should download it to have > URLSearchParams available ? > > wt., 9 lip 2019 o 13:33 Harbs <[email protected]> napisał(a): > >> I see you added that line. It does not look like url.js was modified in >> royale-extras. Why are you downloading it from there? >> >>> On Jul 9, 2019, at 2:26 PM, Piotr Zarzycki <[email protected]> >> wrote: >>> >>> Hi Harbs, >>> >>> Unfortunately I don't see different. externc-config.xml has url.js in >>> target/downloads/browser/url.js. >>> Ant build is downloading url.js to that folder [2]. Maven build is doing >>> exactly the same [3]. >>> >>> What am I missing ? >>> >>> [1] >>> >> https://github.com/apache/royale-typedefs/blob/952664e244c75f9700e7d9c14bd74283c5a75070/js/src/main/config/externc-config.xml#L89 >>> [2] >>> >> https://github.com/apache/royale-typedefs/blob/952664e244c75f9700e7d9c14bd74283c5a75070/js/build.xml#L116 >>> [3] >>> >> https://github.com/apache/royale-typedefs/blob/952664e244c75f9700e7d9c14bd74283c5a75070/js/pom.xml#L192 >>> >>> Thanks, >>> Piotr >>> >>> wt., 9 lip 2019 o 11:06 Harbs <[email protected]> napisał(a): >>> >>>> Take a look at the following files in the typedef repo: >>>> Lines 108-166 in build.xml >>>> Line 67 and later in pom.xml >>>> Notice the different paths in externc-config.xml >>>> >>>>> On Jul 9, 2019, at 11:57 AM, Carlos Rovira <[email protected]> >>>> wrote: >>>>> >>>>> So I can add Web Animations API externs there, but this will trigger >> some >>>>> build in extras and royale will pick that in the next build? I'm >> figuring >>>>> if something must be done I extras or just committing there is all that >>>> is >>>>> needed >>>> >>>> >>> >>> -- >>> >>> Piotr Zarzycki >>> >>> Patreon: *https://www.patreon.com/piotrzarzycki >>> <https://www.patreon.com/piotrzarzycki>* >> >> > > -- > > Piotr Zarzycki > > Patreon: *https://www.patreon.com/piotrzarzycki > <https://www.patreon.com/piotrzarzycki>*
