Other typedef SWCs beside js.swc should have .js files in them and the compiler should be picking that up and sending it to the Closure Compiler.
However, I think getting missing.js to work will be another level of difficulty because it is part of js.swc. It might be better to create a separate typedefs.swc for the APIs you want to add. HTH, -Alex On 7/9/19, 10:51 AM, "Carlos Rovira" <[email protected]> wrote: ok Alex, I order to look at this in the compiler. Where I can look? if you remember another js that is passed to GCC I could try to follow the same pattern to add missing.js, El mar., 9 jul. 2019 a las 18:39, Alex Harui (<[email protected]>) escribió: > You may need to verify that missing.js APIs get passed to Google Closure > Compiler. I think they don't. So a separate typedefs SWC may need to be > created for it. It may be that other APIs in missing.js get renamed as > well and nobody noticed until now, or by luck, some other API usage was > preventing the rename. > > -Alex > > On 7/9/19, 9:20 AM, "Carlos Rovira" <[email protected]> wrote: > > El mar., 9 jul. 2019 a las 18:03, Alex Harui (<[email protected] > >) > escribió: > > > Did the typedefs for Ant get rebuilt? > > > yes, since I pass a script that makes a full rebuilt > > > > How should HTMLSpanElement have a "animate" API defined for it? > > > > since Element.animate() is the API we are trying to add > > > > > > I’m not sure if we can tell Google Closure Compiler that > HTMLSpanElement > > should have an "animate" API since I think it picks up the externs > for > > built-in browser classes from its own externs, so I don't see how it > would > > know not to rename that property. > > > > We need to tell GCC that Element.animate exists, for this reason the > API > added to missing.js (that maybe could be in other place as we decide). > Right now Royale is recognizing animate right, the problem is again > with > release minification since compiler is renaming methods as yesterday > before > Josh change to the compiler (adding good.require()). Although this > time the > problem although is the same could be caused for a different thing. > > thanks > > Carlos > > > > > > > > HTH, > > -Alex > > > > On 7/9/19, 7:41 AM, "Carlos Rovira" <[email protected]> wrote: > > > > yes, and then after maven build sdk with ANT. > > what seems to fail is ANT SDK build > > > > El mar., 9 jul. 2019 a las 16:25, Piotr Zarzycki (< > > [email protected]>) > > escribió: > > > > > By rebuilding all - You mean that you have build typedefs, > compiler > > and > > > asjs - using Maven and than your app ? > > > > > > wt., 9 lip 2019 o 16:23 Carlos Rovira <[email protected] > > > > > napisał(a): > > > > > > > Hi Piotr, > > > > > > > > I found that still did remove the api from missing.js in > typedefs, > > > removing > > > > that and rebuilding all gives me the following error when > reach to > > the > > > > build SDK with ANT step: > > > > > > > > compile-swf: > > > > > > > > [echo] Compiling libs/Jewel.swc > > > > > > > > [echo] ROYALE_HOME: > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs > > > > > > > > [echo] ROYALE_SWF_COMPILER_HOME: > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs > > > > > > > > [echo] ROYALE_COMPILER_HOME: > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/js > > > > > > > > [java] args: > > > > > > > > [java] > > > > > > > +royalelib=/Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks > > > > > > > > [java] +playerglobal.version=11.1 > > > > > > > > [java] > > +env.AIR_HOME=/Users/carlosrovira/Dev/Air/Sdks/AIR_SDK_25 > > > > > > > > [java] -compiler.strict-xml=true > > > > > > > > [java] -compiler.targets=SWF,JSRoyale > > > > > > > > [java] -metadata.date=07/09/19 16:18 +0200 > > > > > > > > [java] -metadata.dateFormat=MM/dd/yy HH:mm Z > > > > > > > > [java] -swf-debugfile-alias=/org/apache/royale/0.9.6 > > > > > > > > [java] > > > > > > > > > > > > > > -output=/Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Jewel/target/Jewel.swc > > > > > > > > [java] > > > > > > > > > > > > > > -load-config=/Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Jewel/src/main/config/compile-swf-config.xml > > > > > > > > [java] > > > > > > > > > > > > > > -js-load-config=/Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/js-config.xml > > > > > > > > [java] > > > > > > > > > > > > > > -js-load-config+=/Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Jewel/../../js/projects/JewelJS/src/main/config/compile-js-config.xml > > > > > > > > [java] target:SWF > > > > > > > > [java] target:JSRoyale > > > > > > > > [java] COMPC > > > > > > > > [java] Loading configuration: > > > > > > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Jewel/src/main/config/compile-swf-config.xml > > > > > > > > [java] > > > > > > > > [java] 469411 bytes written to > > > > > > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Jewel/target/Jewel.swc > > > > in 2,836 seconds > > > > > > > > [java] COMPCJSCRoyale > > > > > > > > [java] > > > > > > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/itemRenderers/TabBarButtonItemRenderer.as(197): > > > > col: 22 Call to a possibly undefined method animate through a > > reference > > > > with static type HTMLSpanElement. > > > > > > > > [java] > > > > > > > > [java] indicator_content.animate( > > > > > > > > [java] ^ > > > > > > > > [java] > > > > > > > > [java] 5.193542279 seconds > > > > > > > > [java] Java Result: 3 > > > > > > > > > > > > BUILD FAILED > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/build.xml:652: > > The > > > > following error occurred while executing this line: > > > > > > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/build.xml:144: > > > > The following error occurred while executing this line: > > > > > > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/build.xml:373: > > > > The following error occurred while executing this line: > > > > > > > > > > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Jewel/build.xml:85: > > > > The following error occurred while executing this line: > > > > > > > > > > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/Jewel/build.xml:111: > > > > condition satisfied > > > > > > > > > > > > Total time: 6 minutes 15 seconds > > > > > > > > Error:Build stopped - build SDK with ANT > > > > > > > > macbookpro:Source carlosrovira$ > > > > > > > > So I think we have a problems there > > > > > > > > HTH > > > > > > > > Carlos > > > > > > > > > > > > El mar., 9 jul. 2019 a las 16:19, Piotr Zarzycki (< > > > > [email protected]>) > > > > escribió: > > > > > > > > > You did exactly the same as me and for me it doesn't work. > If > > you will > > > > have > > > > > time can you clean your local Maven repository and build > your > > > application > > > > > with usage of your API ? Let me know if it's working. > > > > > Of course do this once build of type-defs will be ready > [1] and > > infra > > > fix > > > > > machine [2] ;) > > > > > > > > > > [1] > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbuilds.apache.org%2Fjob%2FRoyale-typedefs%2F&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607090160&sdata=Fh5sOevXWJY1wmDbKfdE8j1XE4ZetkSaCJ%2F2GwiSn2g%3D&reserved=0 > > > > > [2] > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fissues.apache.org%2Fjira%2Fbrowse%2FINFRA-14861&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607090160&sdata=FvsUNNwDqLtGQP6GhWxyz17EfgAI7MpI30fhaiVguPE%3D&reserved=0 > > > > > > > > > > Thanks, > > > > > Piotr > > > > > > > > > > wt., 9 lip 2019 o 16:08 Carlos Rovira < > [email protected]> > > > > > napisał(a): > > > > > > > > > > > Just added to typedefs web-animations api fro > Royale-extras, > > so now > > > is > > > > > easy > > > > > > to try it just changing > > > > > > > > > > > > indicator_content.["animate"]( > > > > > > to > > > > > > indicator_content.animate( > > > > > > > > > > > > El mar., 9 jul. 2019 a las 15:33, Carlos Rovira (< > > > > > [email protected] > > > > > > >) > > > > > > escribió: > > > > > > > > > > > > > Hi Josh, > > > > > > > > > > > > > > I'm finding something similar trying to use .animate > instead > > of > > > > > > ["animate"] > > > > > > > > > > > > > > > > > > > > > COMPILE::JS > > > > > > > public function > animateIndicator(positionDiff:Number, > > > > > widthDiff: > > > > > > > Number, duration:int, easingFunction:String):void > > > > > > > { > > > > > > > indicator_content.animate( > > > > > > > [ > > > > > > > { > > > > > > > transform: "translateX(" + > > positionDiff + > > > > "px) > > > > > > > scaleX(" + widthDiff + ")" > > > > > > > }, > > > > > > > { > > > > > > > transform: "none" > > > > > > > } > > > > > > > ] > > > > > > > , > > > > > > > { > > > > > > > duration: duration, > > > > > > > easing: easingFunction, > > > > > > > fill: 'both' > > > > > > > } > > > > > > > ); > > > > > > > } > > > > > > > > > > > > > > debug works ok, but release mode shows this error: > > > > > > > > > > > > > > [Error] TypeError: this.Xl.lH is not a function. (In > > > > > > > 'this.Xl.lH([{transform:'translateX('+a+'px) > > > > > > > > > scaleX('+b+')'},{transform:A}],{duration:e,pH:g,fill:'both'})', > > > > > > > 'this.Xl.lH' is undefined) > > > > > > > dispatchEvent (App.js:108:961) > > > > > > > dispatchEvent (App.js:113:219) > > > > > > > Ul (App.js:735:780) > > > > > > > (función anónima) > > > > > > > nx (App.js:91:245) > > > > > > > Jx (App.js:110:262) > > > > > > > fH (App.js:965:906) > > > > > > > ix (App.js:93) > > > > > > > (función anónima) (App.js:89) > > > > > > > > > > > > > > To try this I added animate externs api to typedefs > locally > > > > temporary, > > > > > so > > > > > > > this can be tested and if works I'll be adding that > API to > > > > > Royale-extras > > > > > > > repo > > > > > > > > > > > > > > do you see why in this case this is minifying when it > > shouldn't? > > > > > > > > > > > > > > thanks > > > > > > > > > > > > > > > > > > > > > > > > > > > > El lun., 8 jul. 2019 a las 23:06, Carlos Rovira (< > > > > > > [email protected]>) > > > > > > > escribió: > > > > > > > > > > > > > >> Hi Josh! > > > > > > >> > > > > > > >> Awesome! you fix it! :)) > > > > > > >> I rebuild all and rebuild TDJ and is working right > now! :) > > > > > > >> I want to updated it with some little things, but > could not > > do it > > > > with > > > > > > >> that problem. I think your finding was very important > to > > get to > > > > avoid > > > > > > that > > > > > > >> random behavior > > > > > > >> > > > > > > >> Thanks for solving this and so fast Josh! :-) > > > > > > >> > > > > > > >> Carlos > > > > > > >> > > > > > > >> > > > > > > >> El lun., 8 jul. 2019 a las 22:43, Josh Tynjala (< > > > > > > >> [email protected]>) escribió: > > > > > > >> > > > > > > >>> This doesn't seem to be related to any recent > changes in > > the > > > > > compiler. > > > > > > It > > > > > > >>> may be one of those cases where Closure decided to > start > > renaming > > > > > > >>> something > > > > > > >>> that it didn't rename previously due to some file > size > > heuristic > > > > > being > > > > > > >>> triggered, or something like that. > > > > > > >>> > > > > > > >>> I've found that the generation of the "Royale > Dependency > > List" > > > did > > > > > not > > > > > > >>> seem > > > > > > >>> account for externs that were not referenced > directly by > > the > > > > > > application. > > > > > > >>> If the extern was compiled into a SWC and was only > > referenced by > > > > > > classes > > > > > > >>> in > > > > > > >>> the same SWC, the extern would be ignored when > compiling > > the > > > > > > application. > > > > > > >>> In this case, the Alert class in JewelJS.swc is > referencing > > > > > > >>> dialogPolyfill, > > > > > > >>> but the application doesn't use dialogPolyfill > directly. > > As soon > > > > as I > > > > > > >>> add a > > > > > > >>> reference to dialogPolyfill somewhere in the > application, > > it > > > starts > > > > > > >>> working > > > > > > >>> correctly. > > > > > > >>> > > > > > > >>> I changed to compiler to always output goog.require() > > calls for > > > > > > externs. > > > > > > >>> Previously, it was skipping externs completely when > adding > > > > > > goog.require() > > > > > > >>> calls. I guess that this edge case must have been > missed > > when > > > > testing > > > > > > >>> that. > > > > > > >>> > > > > > > >>> -- > > > > > > >>> Josh Tynjala > > > > > > >>> Bowler Hat LLC < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607090160&sdata=Y3X9H%2B%2ByCCvTEu6VVeIvc7cR2cBLDRF8asW6vTIDCWw%3D&reserved=0 > > > > > > > > > >>> > > > > > > >>> > > > > > > >>> On Mon, Jul 8, 2019 at 11:09 AM Carlos Rovira < > > > > > [email protected] > > > > > > > > > > > > > >>> wrote: > > > > > > >>> > > > > > > >>> > Hi, > > > > > > >>> > > > > > > > >>> > when I compile TDJ I can see not a problem in > release > > (but not > > > I > > > > > > >>> debug) for > > > > > > >>> > jewel alert component. > > > > > > >>> > > > > > > > >>> > I think is a magnification problem for > dialogPolyfill. I > > think > > > > > Royale > > > > > > >>> is > > > > > > >>> > changing method name in release mode for method > > > "registerDialog" > > > > > > >>> > This was not happening before > > > > > > >>> > > > > > > > >>> > [Error] TypeError: dialogPolyfill.DH is not a > function. > > (In > > > > > > >>> > 'dialogPolyfill.DH(a.Vi)', 'dialogPolyfill.DH' is > > undefined) > > > > > > >>> > IJ (App.js:1506:197) > > > > > > >>> > showModal (App.js:1507) > > > > > > >>> > cG (App.js:1506:439) > > > > > > >>> > L (App.js:1262) > > > > > > >>> > (función anónima) > > > > > > >>> > nx (App.js:91:245) > > > > > > >>> > Jx (App.js:110:262) > > > > > > >>> > fH (App.js:965:906) > > > > > > >>> > ix (App.js:93) > > > > > > >>> > (función anónima) (App.js:89) > > > > > > >>> > > > > > > > >>> > the class is this: > > > > > > >>> > > > > > > > >>> > package > > > > > > >>> > { > > > > > > >>> > /** > > > > > > >>> > * @externs > > > > > > >>> > */ > > > > > > >>> > public class dialogPolyfill > > > > > > >>> > { > > > > > > >>> > COMPILE::JS > > > > > > >>> > public static function > > > > registerDialog(dialog:Element):void > > > > > {} > > > > > > >>> > } > > > > > > >>> > } > > > > > > >>> > > > > > > > >>> > Someone knows what of the latest changes in > compiler > > could be > > > > > causing > > > > > > >>> this > > > > > > >>> > problem? > > > > > > >>> > > > > > > > >>> > thanks > > > > > > >>> > > > > > > > >>> > -- > > > > > > >>> > Carlos Rovira > > > > > > >>> > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607090160&sdata=52gOBdmEadnW%2BCp83Y44PSS8U7IXKSx79rS8MZblGbo%3D&reserved=0 > > > > > > >>> > > > > > > > >>> > > > > > > >> > > > > > > >> > > > > > > >> -- > > > > > > >> Carlos Rovira > > > > > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607100148&sdata=i9cnwkWz8xB7CBWvlbd9Y37uVLpw1gGUmUk5mnvaH3M%3D&reserved=0 > > > > > > >> > > > > > > >> > > > > > > > > > > > > > > -- > > > > > > > Carlos Rovira > > > > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607100148&sdata=i9cnwkWz8xB7CBWvlbd9Y37uVLpw1gGUmUk5mnvaH3M%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > Carlos Rovira > > > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607100148&sdata=i9cnwkWz8xB7CBWvlbd9Y37uVLpw1gGUmUk5mnvaH3M%3D&reserved=0 > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > > > Piotr Zarzycki > > > > > > > > > > Patreon: * > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607100148&sdata=FYYjIUgAOY9gYbzYqwwzv1jVbUdgO%2BGjwoXqNESG4cs%3D&reserved=0 > > > > > < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607100148&sdata=FYYjIUgAOY9gYbzYqwwzv1jVbUdgO%2BGjwoXqNESG4cs%3D&reserved=0 > > >* > > > > > > > > > > > > > > > > > -- > > > > Carlos Rovira > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607100148&sdata=i9cnwkWz8xB7CBWvlbd9Y37uVLpw1gGUmUk5mnvaH3M%3D&reserved=0 > > > > > > > > > > > > > -- > > > > > > Piotr Zarzycki > > > > > > Patreon: * > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607100148&sdata=FYYjIUgAOY9gYbzYqwwzv1jVbUdgO%2BGjwoXqNESG4cs%3D&reserved=0 > > > < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607100148&sdata=FYYjIUgAOY9gYbzYqwwzv1jVbUdgO%2BGjwoXqNESG4cs%3D&reserved=0 > > >* > > > > > > > > > -- > > Carlos Rovira > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607100148&sdata=i9cnwkWz8xB7CBWvlbd9Y37uVLpw1gGUmUk5mnvaH3M%3D&reserved=0 > > > > > > > > -- > Carlos Rovira > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607110147&sdata=cKEVG7tCjstsUGmoEUydx%2FjYOOCqQOziYhTrkznoVX4%3D&reserved=0 > > > -- Carlos Rovira https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7C8d3f2d3b0c4e40a6fe4908d70495ffcb%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636982914607110147&sdata=cKEVG7tCjstsUGmoEUydx%2FjYOOCqQOziYhTrkznoVX4%3D&reserved=0
