You are basically saying that in case of Maven I should try to move it as an standard module build.
In case of Ant build I will try to figure it out - if I won't be able to I will wait to your free cycles. Thanks, Piotr pon., 26 sie 2019 o 16:39 Josh Tynjala <joshtynj...@bowlerhat.dev> napisał(a): > I guess that I completely forgot to add RoyaleUnit to the Maven build. > Someone else must have added it to the "broken" thing because I have no > idea what that is. > > With the Ant build, I tried my best to copy what the build was doing with > the other libraries. I guess this means that I missed some important > detail. I can take a look, but I won't have time until the first week of > September. > > - Josh > > On Monday, August 26, 2019, Piotr Zarzycki <piotrzarzyck...@gmail.com> > wrote: > > Hi Josh, > > > > You were working on RoyaleUnit ? I see that it is not even part of Maven > > build but it is part of profile "brokenbuild" [1]. In case of ANT see > that > > this module is part of the build, but obviously something doesn't work in > > the end. [2] > > > > I'm not sure what actually I should do with that ? > > > > [1] > > > > https://github.com/apache/royale-asjs/blob/4a3cb8864d2df2ba4e028e07d9cda9215373c42c/frameworks/projects/pom.xml#L76 > > [2] > > > > https://github.com/apache/royale-asjs/blob/4a3cb8864d2df2ba4e028e07d9cda9215373c42c/frameworks/build.xml#L116 > > > > Thanks, > > Piotr > > > > pon., 26 sie 2019 o 10:19 Piotr Zarzycki <piotrzarzyck...@gmail.com> > > napisał(a): > > > >> Alex, > >> > >> I see what is happening. I had the same issue when I was preparing Maven > >> artifacts - I think so. Royale unit is not part of final src zip -> > >> https://ibb.co/44ByBKV > >> > >> I have to figure out how add it there. > >> > >> Thanks, > >> Piotr > >> > >> pon., 26 sie 2019 o 08:35 Alex Harui <aha...@adobe.com.invalid> > >> napisał(a): > >> > >>> The two zips are different. > >>> > >>> The second zip contains several files that the first one doesn't. Try > >>> using other diff tools to find one that will help you see the > differences. > >>> I just use my Mac's *nix command line with "diff -rwq" and "find". > Cygwin > >>> and GitBash should have those tools on Windows. I didn't take the time > to > >>> find out. > >>> > >>> The second zip has two extra folders: > >>> > >>> royale-asjs/js/lib/ with two jars in it. Those jars should be cleaned > by > >>> Ant, but maybe they were in use and thus locked. > >>> > > second/royale-asjs/frameworks/js/projects/RoyaleUnitJS/src/test/royale/target > >>> with lots of files in it. These files may not be getting cleaned by > Ant > >>> scripts since RoyaleUnit is a new library. > >>> > >>> Maybe you ran step 13 in a folder where it had already run? > >>> > >>> I'm done working for today. Will check in my morning. > >>> > >>> HTH, > >>> -Alex > >>> > >>> > >>> > >>> On 8/25/19, 11:08 PM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> > >>> wrote: > >>> > >>> Links: > >>> > >>> zip1: > >>> > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2F1drv.ms%2Fu%2Fs!ApVpLyjpHDC2ic0S8UffcFPmhXGKGQ%3Fe%3DZstLev&data=02%7C01%7Caharui%40adobe.com%7Cee362a70359f471e8aed08d729ebc5cc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637023964926048393&sdata=2LuY8Zl6krXiKSqrhXJkm8xN01uwQq1aQ9ap9NZsTfY%3D&reserved=0 > >>> zip2: > >>> > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2F1drv.ms%2Fu%2Fs!ApVpLyjpHDC2ic0TPORa2P9OKsWRiw%3Fe%3Dk8fQ7T&data=02%7C01%7Caharui%40adobe.com%7Cee362a70359f471e8aed08d729ebc5cc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637023964926048393&sdata=shpNZi76ycOzZnlaqD2HPBuVPZJcju%2F6Ud1ERZXTKvo%3D&reserved=0 > >>> > >>> Thanks, > >>> Piotr > >>> > >>> pon., 26 sie 2019 o 00:48 Alex Harui <aha...@adobe.com.invalid> > >>> napisał(a): > >>> > >>> > Looks like there are 130 files in the "left" folder that aren't > in > >>> the > >>> > "right"? Or I don't understand the output of whatever tool you > are > >>> using. > >>> > Post a link to the two zips if you want. > >>> > > >>> > HTH, > >>> > -Alex > >>> > > >>> > On 8/25/19, 3:08 PM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com > > > >>> wrote: > >>> > > >>> > Content in both zips is exactly the same. I don't see now the > >>> reason > >>> > to do > >>> > not move forward with that -> > >>> > > >>> > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fibb.co%2FXzDDVfd&data=02%7C01%7Caharui%40adobe.com%7Cee362a70359f471e8aed08d729ebc5cc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637023964926048393&sdata=rCZxV%2BFdCCrpZxoGfNrN9Jq%2Bkg2xx91fLf6mX%2FZMY3A%3D&reserved=0 > >>> > > >>> > pon., 26 sie 2019 o 00:01 Piotr Zarzycki < > >>> piotrzarzyck...@gmail.com> > >>> > napisał(a): > >>> > > >>> > > Sorry that's not my day. It looks like my folder in Total > >>> Commander > >>> > wasn't > >>> > > refreshed. Both zips exists. I will compare them and > provide > >>> results. > >>> > > > >>> > > On Sun, Aug 25, 2019, 11:58 PM Piotr Zarzycki < > >>> > piotrzarzyck...@gmail.com> > >>> > > wrote: > >>> > > > >>> > >> Alex, > >>> > >> > >>> > >> I just checked and I was mistake. Zip which should be > inside > >>> source > >>> > >> folder is not exists at all. I'm wondering what could > happen > >>> that > >>> > this zip > >>> > >> wasn't generated. > >>> > >> > >>> > >> Thanks, > >>> > >> Piotr > >>> > >> > >>> > >> On Sun, Aug 25, 2019, 11:52 PM Alex Harui > >>> <aha...@adobe.com.invalid > >>> > > > >>> > >> wrote: > >>> > >> > >>> > >>> The output says the -src.zip did not compare. Expand the > >>> two zip > >>> > files > >>> > >>> into different folders and compare the folders. > >>> > >>> > >>> > >>> HTH, > >>> > >>> -Alex > >>> > >>> > >>> > >>> On 8/25/19, 2:45 PM, "Piotr Zarzycki" < > >>> piotrzarzyck...@gmail.com> > >>> > >>> wrote: > >>> > >>> > >>> > >>> Hi, > >>> > >>> > >>> > >>> I have spend another hours on release. Maven > artifacts > >>> are > >>> > deployed > >>> > >>> to the > >>> > >>> staging without the problem. I stopped this time and > >>> the very > >>> > end of > >>> > >>> the > >>> > >>> process, where I need to prepare ANT artifacts. Build > >>> on my PC > >>> > >>> failed [1] - > >>> > >>> size of compared zips are different - Step 13. > >>> > >>> > >>> > >>> During whole process I had such problem when SWC time > >>> stamp had > >>> > >>> incorrect > >>> > >>> format and in the end I did end up with fail. Maybe > >>> this time > >>> > is the > >>> > >>> same > >>> > >>> story. > >>> > >>> Maybe in that case this is the same. The question is > - > >>> To what > >>> > step > >>> > >>> should > >>> > >>> I really back ? > >>> > >>> Should I remove branch for asjs and start from 11? > >>> > >>> > >>> > >>> My command: > >>> > >>> ant -f releasesteps.xml Release_Step_013 > >>> > -Drelease.version=0.9.6 > >>> > >>> -Droyale.swc-date="8/25/19 9:06 -0800" > >>> > -Dplayerglobal.version=11.7 > >>> > >>> -Dflat.donot.ask=true -Drc=1 -DskipTests=true > >>> > >>> > >>> > >>> It is really pain to me start from scratch, cause > >>> building > >>> > whole > >>> > >>> framework > >>> > >>> on my PC takes ages. Satisfying comparer is > difficult. > >>> > >>> > >>> > >>> [1] > >>> > >>> > >>> > > >>> > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpaste.apache.org%2Fs8i7r&data=02%7C01%7Caharui%40adobe.com%7Cee362a70359f471e8aed08d729ebc5cc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637023964926048393&sdata=WmyS3gG4jdP0oMroPRFufMgNTKSI4yjUFmqLPzr47j4%3D&reserved=0 > >>> > >>> > >>> > >>> Thanks, > >>> > >>> Piotr > >>> > >>> > >>> > >>> pt., 16 sie 2019 o 18:27 Alex Harui > >>> <aha...@adobe.com.invalid> > >>> > >>> napisał(a): > >>> > >>> > >>> > >>> > Piotr, > >>> > >>> > > >>> > >>> > At this point, I would definitely recommend trying > >>> the three > >>> > steps > >>> > >>> without > >>> > >>> > any changes to the release_steps.xml file and use > an > >>> ABSOLUTE > >>> > >>> path. That's > >>> > >>> > the only way I tested the scripts. I did not try a > >>> relative > >>> > path, > >>> > >>> and I > >>> > >>> > highly recommend not putting all of these files in > a > >>> working > >>> > >>> copy. It is > >>> > >>> > probably less work to just have RM's specify an > >>> absolute path > >>> > >>> external to > >>> > >>> > the working copy. Using "../.." may not work > >>> consistently > >>> > so do > >>> > >>> not use > >>> > >>> > those adjustments. > >>> > >>> > > >>> > >>> > Capture the logs for all 3 steps and if there is a > >>> problem > >>> > post > >>> > >>> the output. > >>> > >>> > > >>> > >>> > Thanks, > >>> > >>> > -Alex > >>> > >>> > > >>> > >>> > > >>> > >>> > On 8/16/19, 2:57 AM, "Piotr Zarzycki" < > >>> > piotrzarzyck...@gmail.com> > >>> > >>> wrote: > >>> > >>> > > >>> > >>> > It looks like this is again problem with > >>> RoyaleUnit[1]. > >>> > Here > >>> > >>> is the > >>> > >>> > results > >>> > >>> > of comparison. I'm not sure why left folder > >>> doesn't > >>> > contains > >>> > >>> files. > >>> > >>> > > >>> > >>> > [1] > >>> > >>> > > >>> > >>> > >>> > > >>> > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpasteboard.co%2FIsWnHGq.png&data=02%7C01%7Caharui%40adobe.com%7Cee362a70359f471e8aed08d729ebc5cc%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637023964926048393&sdata=w0ixJ5SmSTDQbC7gMpzTit5MTQkZBFsHerit8qf%2FYvU%3D&reserved=0 > >>> > >>> > > >>> > >>> > Thanks, > >>> > >>> > Piotr > >>> > >>> > > >>> > >>> > pt., 16 sie 2019 o 11:08 Piotr Zarzycki < > >>> > >>> piotrzarzyck...@gmail.com> > >>> > >>> > napisał(a): > >>> > >>> > > >>> > >>> > > Ok I was mistake. Both zips exists, but they > >>> have > >>> > different > >>> > >>> sizes! So > >>> > >>> > > comparison went fine and I need to understand > >>> one > >>> > sources are > >>> > >>> > different... > >>> > >>> > > > >>> > >>> > > pt., 16 sie 2019 o 10:59 Piotr Zarzycki < > >>> > >>> piotrzarzyck...@gmail.com> > >>> > >>> > > napisał(a): > >>> > >>> > > > >>> > >>> > >> I have analyzed that target > (compare-src-zips) > >>> and it > >>> > >>> compares zip > >>> > >>> > file > >>> > >>> > >> in following locations: > >>> > >>> > >> > >>> > >>> > >> 1) artifacts\apache-royale-0.9.6-src.zip > >>> > >>> > >> 2) > /sources/srczip/apache-royale-0.9.6-src.zip > >>> > >>> > >> > >>> > >>> > >> I have changed in that target all places > where > >>> > >>> ${artifactfolder} to > >>> > >>> > >> ../../${artifactfolder} and launch that > >>> target. It > >>> > looks > >>> > >>> like zip > >>> > >>> > file > >>> > >>> > >> wasn't created at all in location: > >>> > >>> > >> /sources/srczip/apache-royale-0.9.6-src.zip. > >>> > >>> > >> > >>> > >>> > >> I will try to figure out what has happened. > >>> Btw. I > >>> > didn't > >>> > >>> commit my > >>> > >>> > >> changes with ../../ - those are local. > >>> > >>> > >> > >>> > >>> > >> Thanks, > >>> > >>> > >> Piotr > >>> > >>> > >> > >>> > >>> > >> pt., 16 sie 2019 o 09:29 Piotr Zarzycki < > >>> > >>> piotrzarzyck...@gmail.com> > >>> > >>> > >> napisał(a): > >>> > >>> > >> > >>> > >>> > >>> Unfortunately I don't know what is > happening > >>> but > >>> > signing > >>> > >>> trough > >>> > >>> > script > >>> > >>> > >>> hang for me. Stopped working. :( > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> > >>> ant -f releasesteps.xml > Release_Step_003_Sign > >>> > >>> > -Drelease.version=0.9.6 > >>> > >>> > >>> Buildfile: > >>> > >>> d:\Work\royale-sources\royale-compiler\releasesteps.xml > >>> > >>> > >>> > >>> > >>> > >>> get-artifact-folder: > >>> > >>> > >>> [input] Enter the temporary folder to > >>> store the > >>> > >>> downloaded > >>> > >>> > artifacts: > >>> > >>> > >>> royale096 > >>> > >>> > >>> > >>> > >>> > >>> Release_Step_003_Sign: > >>> > >>> > >>> > >>> > >>> > >>> sign-file: > >>> > >>> > >>> > >>> > >>> > > -- > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > -- Piotr Zarzycki Patreon: *https://www.patreon.com/piotrzarzycki <https://www.patreon.com/piotrzarzycki>*
