I thought about pushing it before Piotr even asked, but I figured that a
solution more like yours was necessary. I could tell that my change would
require SWF, and I know that we want a JS-only option too.
- Josh
On Friday, September 20, 2019, Alex Harui <aha...@adobe.com.invalid> wrote:
> Correct. ApproveRoyale.xml is not even in the source package. I just
didn't want Josh to push that change.
>
> -Alex
>
> On 9/20/19, 9:16 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com> wrote:
>
> Alex,
>
> Second issue is a blocker only for someone who wanted to developing
Royale
> SDK, from my perspective it is not a blocker for a release.
>
> Thanks,
> Piotr
>
> pt., 20 wrz 2019 o 18:13 Alex Harui <aha...@adobe.com.invalid>
napisał(a):
>
> > Specifically, requiring the profile generate-swcs-for-swf will fail
when
> > running ApproveRoyale.xml in a js-only configuration.
> >
> > My commit last night detects env.AIR_HOME and selects the set of
profiles
> > to use. I saw it work for both js-only and js-swf configurations.
> >
> > -Alex
> >
> > On 9/20/19, 9:02 AM, "Piotr Zarzycki" <piotrzarzyck...@gmail.com>
wrote:
> >
> > What won't work exactly ? Build ? Or Royale for user IDE ?
> >
> > pt., 20 wrz 2019 o 17:57 Alex Harui <aha...@adobe.com.invalid>
> > napisał(a):
> >
> > > Please don't commit that. It won't work for js-only.
> > >
> > > I pushed a solution for both last night.
> > >
> > > Thanks,
> > > -Alex
> > >
> > > On 9/19/19, 11:20 PM, "Piotr Zarzycki" <
piotrzarzyck...@gmail.com>
> > wrote:
> > >
> > > Hi Josh,
> > >
> > > Maybe you could commit that to develop?
> > >
> > > Thanks,
> > > Piotr
> > >
> > > czw., 19 wrz 2019 o 18:19 Josh Tynjala <
> > joshtynj...@bowlerhat.dev>
> > > napisał(a):
> > >
> > > > If anyone else has problems with the Maven build when
running
> > the
> > > > ApproveRoyale.xml script, I was able to fix it by
modifying
> > this
> > > section
> > > > where the framework is built:
> > > >
> > > > <exec executable="${mvn}"
> > > > dir="${basedir}/${maven.package.url.name}/royale-asjs"
> > > > failonerror="true">
> > > > <arg value="-P"/>
> > > > <arg value="generate-swcs-for-swf,main"/>
> > > > <arg value="clean"/>
> > > > <arg value="install"/>
> > > > </exec>
> > > >
> > > > --
> > > > Josh Tynjala
> > > > Bowler Hat LLC <
> > >
> >
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7C295afd2376244230fd8c08d73de5f4ac%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637045930174281142&sdata=B8zm7Zv%2FWJGSSdLUH9bQo%2FgDnGRBHfy5ULTxufNqE5Q%3D&reserved=0
> > > >
> > > >
> > > >
> > > > On Thu, Sep 19, 2019 at 1:08 AM Apache Royale CI Server
<
> > > > apacheroyal...@gmail.com> wrote:
> > > >
> > > > > This is the discussion thread.
> > > > >
> > > > > Thanks,
> > > > > Piotr
> > > >
> > >
> > >
> > > --
> > >
> > > Piotr Zarzycki
> > >
> > > Patreon: *
> > >
> >
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C295afd2376244230fd8c08d73de5f4ac%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637045930174281142&sdata=sRFTeemaBdq%2BS83rK52vAIuAmWMmZJ42Agi9YDAjyQI%3D&reserved=0
> > > <
> > >
> >
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C295afd2376244230fd8c08d73de5f4ac%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637045930174281142&sdata=sRFTeemaBdq%2BS83rK52vAIuAmWMmZJ42Agi9YDAjyQI%3D&reserved=0
> > > >*
> > >
> > >
> > >
> >
> > --
> >
> > Piotr Zarzycki
> >
> > Patreon: *
> >
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C295afd2376244230fd8c08d73de5f4ac%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637045930174281142&sdata=sRFTeemaBdq%2BS83rK52vAIuAmWMmZJ42Agi9YDAjyQI%3D&reserved=0
> > <
> >
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C295afd2376244230fd8c08d73de5f4ac%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637045930174281142&sdata=sRFTeemaBdq%2BS83rK52vAIuAmWMmZJ42Agi9YDAjyQI%3D&reserved=0
> > >*
> >
> >
> >
>
> --
>
> Piotr Zarzycki
>
> Patreon: *
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C295afd2376244230fd8c08d73de5f4ac%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637045930174281142&sdata=sRFTeemaBdq%2BS83rK52vAIuAmWMmZJ42Agi9YDAjyQI%3D&reserved=0
> <
https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7C295afd2376244230fd8c08d73de5f4ac%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637045930174281142&sdata=sRFTeemaBdq%2BS83rK52vAIuAmWMmZJ42Agi9YDAjyQI%3D&reserved=0
>*
>
>
>
--
--
Josh Tynjala
Bowler Hat LLC <https://bowlerhat.dev>
