Thank you, Alex! I tried your changes with adobe/royale artifacts deleted from .m2, and I was able to get through both js and js-swf builds successfully.
Carlos, I think that these changes will allow you to get through the process now too. For everyone's convenience, here's a link to the latest ApproveRoyale.xml script for 0.9.6: https://github.com/apache/royale-asjs/blob/release/0.9.6/ApproveRoyale.xml Use this one instead of the one linked from the [VOTE] thread. Just to be clear, since ApproveRoyale.xml is a convenience script for PMC members to aid with the release voting process, and not something that end users or potential contributors need to use, these latest changes to ApproveRoyale.xml don't require the creation of a new RC. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Thu, Sep 26, 2019 at 11:34 AM Alex Harui <aha...@adobe.com.invalid> wrote: > Yeah, I just saw that myself. That's because I didn't merge in my changes > correctly. I just pushed one that seems to be working better. > > -Alex > > On 9/26/19, 10:27 AM, "Josh Tynjala" <joshtynj...@bowlerhat.dev> wrote: > > Thanks, Alex. The ApproveRoyale.mxml from the latest release/0.9.6 is > working for me if I delete all adobe/royale artifacts from my .m2, and > if I > omit -Duse-flash=true. However, with -Duse-flash=true, I'm seeing > compiler > errors when Maven tries to build the SWF version of Binding.swc. > > A couple of examples of the errors (there are many more): > > > /Users/joshtynjala/Desktop/royale/apache-royale-0.9.6-maven-src/royale-asjs/frameworks/projects/Binding/src/main/royale/org/apache/royale/binding/ApplicationDataBinding.as(23): > col: 12 Warning: Definition org.apache.royale.core.IBinding could not > be > found. > > import org.apache.royale.core.IBinding; > ^ > > > /Users/joshtynjala/Desktop/royale/apache-royale-0.9.6-maven-src/royale-asjs/frameworks/projects/Binding/src/main/royale/org/apache/royale/binding/ApplicationDataBinding.as(27): > col: 12 Warning: Definition org.apache.royale.core.IBead could not be > found. > > import org.apache.royale.core.IBead; > ^ > > Could it be because you removed the asjs_mvn_defines from > ApproveRoyale.xml > in your new commit that added inputstring="Yes"? I added that back in, > and > my change seemed to allow me to finish the script successfully with > -Duse-flash=true. > > -- > Josh Tynjala > Bowler Hat LLC < > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201507168&sdata=aZr5SvuHu%2Fo%2BWc1EF7MRosekWVMeAqC9yudOoLTe3uo%3D&reserved=0 > > > > > On Thu, Sep 26, 2019 at 12:47 AM Alex Harui <aha...@adobe.com.invalid> > wrote: > > > Looks like I missed a commit. I just pushed the ApproveRoyale.xml I > was > > using to the release branch. > > > > Try that one and see if it works better. It shouldn't require the > > workaround you used. > > > > Thanks, > > -Alex > > > > On 9/25/19, 4:16 PM, "Josh Tynjala" <joshtynj...@bowlerhat.dev> > wrote: > > > > To get the system property working with ApproveRoyale.xml, I > added the > > following line to each of the mvn commands in my local copy of > > ApproveRoyale.xml: > > > > <arg > > > > > value="-Dcom.adobe.systemIdsForWhichTheTermsOfTheAdobeLicenseAgreementAreAccepted=499700b6"/> > > > > This should work for anyone using Bash's yes command to quickly > > approve the > > license headers (after you've already done it once manually, of > > course). > > > > yes | ant -e -f ApproveRoyale.xml -Drelease.version=0.9.6 -Drc=3 > > > > -- > > Josh Tynjala > > Bowler Hat LLC < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201507168&sdata=aZr5SvuHu%2Fo%2BWc1EF7MRosekWVMeAqC9yudOoLTe3uo%3D&reserved=0 > > > > > > > > > On Wed, Sep 25, 2019 at 2:58 PM Josh Tynjala < > > joshtynj...@bowlerhat.dev> > > wrote: > > > > > I deleted all com.adobe artifacts in my Maven .m2 folder, and > I can > > see > > > the prompt to accept the license for the Adobe dependencies. > > > > > > The build output suggests that you can set a system property to > > accept the > > > agreement, so I tried adding that property to my command, like > this: > > > > > > ant -e -f ApproveRoyale.xml -Drelease.version=0.9.6 -Drc=3 > > > > > > -Dcom.adobe.systemIdsForWhichTheTermsOfTheAdobeLicenseAgreementAreAccepted=XXXXXXXX > > > > > > (Where XXXXXXXX is replaced by my real system ID) > > > > > > However, it still asked me to accept the agreement. Perhaps > this > > system > > > property isn't getting inherited by the Maven build. > > > > > > I am using the RC3 ApproveRoyale.xml linked from the Vote > thread, > > and not > > > an older one. > > > > > > -- > > > Josh Tynjala > > > Bowler Hat LLC < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbowlerhat.dev&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201507168&sdata=aZr5SvuHu%2Fo%2BWc1EF7MRosekWVMeAqC9yudOoLTe3uo%3D&reserved=0 > > > > > > > > > > > > On Wed, Sep 25, 2019 at 11:25 AM Carlos Rovira < > > carlosrov...@apache.org> > > > wrote: > > > > > >> Hi > > >> I tried in the meanwhile with your settings and enter in the > > endless loop > > >> as in RC2 > > >> > > >> I'll try to run now adding that to the command and report back > > >> > > >> > > >> El mié., 25 sept. 2019 a las 18:59, Piotr Zarzycki (< > > >> piotrzarzyck...@gmail.com>) escribió: > > >> > > >> > The same issue as it was previously. You are missing > playerglobal > > - I > > >> don't > > >> > know why at all. You can try to switch to my settings - > don't > > forget > > >> update > > >> > link to maven artifacts in it. > > >> > > > >> > I'm not sure also but maybe you should try to run approve > script > > with > > >> this > > >> > one: -Dgenerate.swf.swcs=true and -DskipTests=true. > > >> > > > >> > śr., 25 wrz 2019 o 18:41 Carlos Rovira < > carlosrov...@apache.org> > > >> > napisał(a): > > >> > > > >> > > Hi, > > >> > > > > >> > > sorry to report that my try failed. I tried with clean > .m2 and > > my own > > >> > > settings.xml. Maybe I need to switch to the settings > Piotr send > > to me? > > >> > > > > >> > > as well I used the instruction provided in email: ant -e > -f > > >> > > ApproveRoyale.xml -Drelease.version=0.9.6 -Drc=3 > > >> > > > > >> > > > > >> > > ache.org/maven2/org/antlr/antlr/3.4/antlr-3.4.jar (1.1 > MB at > > 2.7 > > >> > > MB/s)[INFO] > > >> > > > > >> > > > ------------------------------------------------------------------------ > > >> > > > > >> > > [INFO] Reactor Build Order: > > >> > > > > >> > > [INFO] > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Parent > > >> > > [pom] > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Compiler-Common > > >> > > [jar] > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Test Utils > > >> > > [jar] > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Externc > > >> > > [jar] > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Compiler > > >> > > [jar] > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Compiler-JX > > >> > > [jar] > > >> > > > > >> > > [INFO] Apache Royale: Compiler: SWFUtils > > >> > > [jar] > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Debugger > > >> > > [jar] > > >> > > > > >> > > [INFO] Apache Royale: Compiler: OEM Layer > > >> > > [jar] > > >> > > > > >> > > [INFO] Apache Royale: Royale Ant Tasks > > >> > > [jar] > > >> > > > > >> > > [INFO] Apache Royale: RoyaleUnit Ant Tasks > > >> > > [jar] > > >> > > > > >> > > [INFO] Apache Royale: Royale Maven Plugin > > >> > > [maven-plugin] > > >> > > > > >> > > [INFO] > > >> > > > > >> > > [INFO] ---------< > > org.apache.royale.compiler:royale-compiler-parent > > >> > > >---------- > > >> > > > > >> > > [INFO] Building Apache Royale: Compiler: Parent 0.9.6 > > >> > > [1/12] > > >> > > > > >> > > [INFO] --------------------------------[ pom > > >> > > ]--------------------------------- > > >> > > > > >> > > Downloading from apache-release: > > >> > > > > >> > > > > >> > > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Freleases%2Fcom%2Fadobe%2Fflash%2Fframework%2Fplayerglobal%2F20.0%2Fplayerglobal-20.0.pom&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201507168&sdata=5d71xoqtiFvVcbgOLMoD5Gucl9dE6lRvNiVhsDs5Hag%3D&reserved=0 > > >> > > > > >> > > Downloading from central: > > >> > > > > >> > > > > >> > > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepo.maven.apache.org%2Fmaven2%2Fcom%2Fadobe%2Fflash%2Fframework%2Fplayerglobal%2F20.0%2Fplayerglobal-20.0.pom&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201507168&sdata=%2Fa5AefWK5iYVSOyDWLfZKc%2F0Seuk4qowIudA82P9gKU%3D&reserved=0 > > >> > > > > >> > > [WARNING] The POM for > > com.adobe.flash.framework:playerglobal:swc:20.0 > > >> is > > >> > > missing, no dependency information available > > >> > > > > >> > > Downloading from apache-release: > > >> > > > > >> > > > > >> > > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Freleases%2Fcom%2Fadobe%2Fflash%2Fframework%2Fplayerglobal%2F20.0%2Fplayerglobal-20.0.swc&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201507168&sdata=0artht51xa1z5WnU5M1kFBb0vNczI7RZ7jsQbZw9mWM%3D&reserved=0 > > >> > > > > >> > > Downloading from central: > > >> > > > > >> > > > > >> > > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepo.maven.apache.org%2Fmaven2%2Fcom%2Fadobe%2Fflash%2Fframework%2Fplayerglobal%2F20.0%2Fplayerglobal-20.0.swc&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201517162&sdata=1lmdgcwyJIwIC7kNoLDr57ncOI7FwYCRskQtagizHQA%3D&reserved=0 > > >> > > > > >> > > [INFO] > > >> > > > > >> > > > ------------------------------------------------------------------------ > > >> > > > > >> > > [INFO] Reactor Summary for Apache Royale: Compiler: Parent > > 0.9.6: > > >> > > > > >> > > [INFO] > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Parent > .................... > > FAILURE [ > > >> > > 0.982 s] > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Compiler-Common > ........... > > SKIPPED > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Test Utils > ................ > > SKIPPED > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Externc > ................... > > SKIPPED > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Compiler > .................. > > SKIPPED > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Compiler-JX > ............... > > SKIPPED > > >> > > > > >> > > [INFO] Apache Royale: Compiler: SWFUtils > .................. > > SKIPPED > > >> > > > > >> > > [INFO] Apache Royale: Compiler: Debugger > .................. > > SKIPPED > > >> > > > > >> > > [INFO] Apache Royale: Compiler: OEM Layer > ................. > > SKIPPED > > >> > > > > >> > > [INFO] Apache Royale: Royale Ant Tasks > .................... > > SKIPPED > > >> > > > > >> > > [INFO] Apache Royale: RoyaleUnit Ant Tasks > ................ > > SKIPPED > > >> > > > > >> > > [INFO] Apache Royale: Royale Maven Plugin > ................. > > SKIPPED > > >> > > > > >> > > [INFO] > > >> > > > > >> > > > ------------------------------------------------------------------------ > > >> > > > > >> > > [INFO] BUILD FAILURE > > >> > > > > >> > > [INFO] > > >> > > > > >> > > > ------------------------------------------------------------------------ > > >> > > > > >> > > [INFO] Total time: 8.438 s > > >> > > > > >> > > [INFO] Finished at: 2019-09-25T18:35:49+02:00 > > >> > > > > >> > > [INFO] > > >> > > > > >> > > > ------------------------------------------------------------------------ > > >> > > > > >> > > [ERROR] Failed to execute goal on project > > royale-compiler-parent: > > >> Could > > >> > not > > >> > > resolve dependencies for project > > >> > > > org.apache.royale.compiler:royale-compiler-parent:pom:0.9.6: > > Could not > > >> > find > > >> > > artifact com.adobe.flash.framework:playerglobal:swc:20.0 > in > > >> > apache-release > > >> > > ( > > >> > > > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Frepository.apache.org%2Fcontent%2Frepositories%2Freleases&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201517162&sdata=UM1VK5ZW2VpSUtRDOYYKh2SxumPGrNTMxQDL3BwKIH0%3D&reserved=0 > ) > > -> > > >> [Help 1] > > >> > > > > >> > > [ERROR] > > >> > > > > >> > > [ERROR] To see the full stack trace of the errors, re-run > Maven > > with > > >> the > > >> > -e > > >> > > switch. > > >> > > > > >> > > [ERROR] Re-run Maven using the -X switch to enable full > debug > > logging. > > >> > > > > >> > > [ERROR] > > >> > > > > >> > > [ERROR] For more information about the errors and possible > > solutions, > > >> > > please read the following articles: > > >> > > > > >> > > [ERROR] [Help 1] > > >> > > > > >> > > > > >> > > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fcwiki.apache.org%2Fconfluence%2Fdisplay%2FMAVEN%2FDependencyResolutionException&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201517162&sdata=SwB76rJ3FLVIl6RKQaTFNTQ8f4QoTNPQHcdey9Wyb9Y%3D&reserved=0 > > >> > > > > >> > > > > >> > > BUILD FAILED > > >> > > > > >> > > > /Users/carlosrovira/Downloads/testrc3/ApproveRoyale.xml:778: The > > >> > following > > >> > > error occurred while executing this line: > > >> > > > > >> > > > /Users/carlosrovira/Downloads/testrc3/ApproveRoyale.xml:801: > > exec > > >> > returned: > > >> > > 1 > > >> > > > > >> > > > > >> > > Total time: 27 minutes 17 seconds > > >> > > > > >> > > macbookpro:testrc3 carlosrovira$ > > >> > > > > >> > > > > >> > > El mié., 25 sept. 2019 a las 17:56, Piotr Zarzycki (< > > >> > > piotrzarzyck...@gmail.com>) escribió: > > >> > > > > >> > > > I'm not sure how it happened this time, but yeah we > finally > > have. ;) > > >> > > > > > >> > > > śr., 25 wrz 2019 o 17:54 Carlos Rovira < > > carlosrov...@apache.org> > > >> > > > napisał(a): > > >> > > > > > >> > > > > Hi Piotr, > > >> > > > > great to see we have different threads in gmail :) > > >> > > > > > > >> > > > > El mié., 25 sept. 2019 a las 16:24, Piotr Zarzycki (< > > >> > > > > piotrzarzyck...@gmail.com>) escribió: > > >> > > > > > > >> > > > > > Ok, new and hopefully the last one RC3. I didn't run > > >> ApproveScript > > >> > > > myself > > >> > > > > > yet, but will do that tomorrow or next week. > > >> > > > > > > > >> > > > > > śr., 25 wrz 2019 o 16:23 Apache Royale CI Server < > > >> > > > > apacheroyal...@gmail.com > > >> > > > > > > > > >> > > > > > napisał(a): > > >> > > > > > > > >> > > > > > > This is the discussion thread. > > >> > > > > > > > > >> > > > > > > Thanks, > > >> > > > > > > Piotr > > >> > > > > > > > >> > > > > > > > >> > > > > > > > >> > > > > > -- > > >> > > > > > > > >> > > > > > Piotr Zarzycki > > >> > > > > > > > >> > > > > > Patreon: * > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201517162&sdata=4iebHNQYXpMLR%2FU%2FFNSPU%2Fw9zoExO%2BUCsELib4btZ8E%3D&reserved=0 > > >> > > > > > < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201517162&sdata=4iebHNQYXpMLR%2FU%2FFNSPU%2Fw9zoExO%2BUCsELib4btZ8E%3D&reserved=0 > > >* > > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > -- > > >> > > > > Carlos Rovira > > >> > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201517162&sdata=q4byOmJ2ZbtPTbGKGLRwwr6jmYAdspViZLu6ubAQ5gk%3D&reserved=0 > > >> > > > > > > >> > > > > > >> > > > > > >> > > > -- > > >> > > > > > >> > > > Piotr Zarzycki > > >> > > > > > >> > > > Patreon: * > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201517162&sdata=4iebHNQYXpMLR%2FU%2FFNSPU%2Fw9zoExO%2BUCsELib4btZ8E%3D&reserved=0 > > >> > > > < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201517162&sdata=4iebHNQYXpMLR%2FU%2FFNSPU%2Fw9zoExO%2BUCsELib4btZ8E%3D&reserved=0 > > >* > > >> > > > > > >> > > > > >> > > > > >> > > -- > > >> > > Carlos Rovira > > >> > > > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201517162&sdata=q4byOmJ2ZbtPTbGKGLRwwr6jmYAdspViZLu6ubAQ5gk%3D&reserved=0 > > >> > > > > >> > > > >> > > > >> > -- > > >> > > > >> > Piotr Zarzycki > > >> > > > >> > Patreon: * > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201517162&sdata=4iebHNQYXpMLR%2FU%2FFNSPU%2Fw9zoExO%2BUCsELib4btZ8E%3D&reserved=0 > > >> > < > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.patreon.com%2Fpiotrzarzycki&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201527156&sdata=0KxXOVJHjCj4Zjz2i%2F8fpajsYUGAq3qCtThXq0eaKyQ%3D&reserved=0 > > >* > > >> > > > >> > > >> > > >> -- > > >> Carlos Rovira > > >> > > > https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fabout.me%2Fcarlosrovira&data=02%7C01%7Caharui%40adobe.com%7Cafc4989b7d61427d849a08d742a6bc57%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637051156201527156&sdata=e1Ci7h3G13dse2c3TfmsXzKtQPjKDRPhd%2BMYIwJZuyA%3D&reserved=0 > > >> > > > > > > > > > > > >
