Hi ok. So what I don't understand is what each time I build from scratch the build indicates that 2 files are modified. Should I commit the modifications? and if you created it, is right that the build is updating those 2 files?
thanks! El mar., 3 dic. 2019 a las 16:53, Josh Tynjala (<joshtynj...@bowlerhat.dev>) escribió: > Hi Carlos, > > I think that you are confused because you believe that these files are > generated, but they are not generated. About two weeks ago, I personally > created these files in my own text editor. Here's my original commit where > I added them to the repository: > > > https://github.com/apache/royale-compiler/commit/f0d9176c405c0508255d20a98b095ea21ff4b238 > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Tue, Dec 3, 2019 at 7:18 AM Carlos Rovira <carlosrov...@apache.org> > wrote: > > > Hi Josh, > > just put them back. I'm a bit confused with this files, since we should > not > > have generated files. But as well I can't add it to .gitignore list. > > What should we do with those? > > thanks > > > > El lun., 2 dic. 2019 a las 16:36, Josh Tynjala (< > joshtynj...@bowlerhat.dev > > >) > > escribió: > > > > > These files are not actually generated. Please put them back. > > > > > > -- > > > Josh Tynjala > > > Bowler Hat LLC <https://bowlerhat.dev> > > > > > > > > > On Thu, Nov 28, 2019 at 8:56 AM Carlos Rovira <carlosrov...@apache.org > > > > > wrote: > > > > > > > I was figuring that, but wasn't sure, will remove it > > > > > > > > El jue., 28 nov. 2019 a las 17:04, Alex Harui > > (<aha...@adobe.com.invalid > > > >) > > > > escribió: > > > > > > > > > I haven't built the compiler, but in general we do not want to > commit > > > > > generated files. Why would these be an exception? > > > > > > > > > > -Alex > > > > > > > > > > On 11/28/19, 7:17 AM, "carlosrov...@apache.org" < > > > > carlosrov...@apache.org> > > > > > wrote: > > > > > > > > > > This is an automated email from the ASF dual-hosted git > > repository. > > > > > > > > > > carlosrovira pushed a commit to branch develop > > > > > in repository > > > > > > > > > > > > > > > https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-compiler.git&data=02%7C01%7Caharui%40adobe.com%7Cbe827a0702184edabb1708d774162394%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637105510754711745&sdata=sOb8FVjrZzDwZD2wc1iELgaV6z3OhrxHgHYmmJep8BI%3D&reserved=0 > > > > > > > > > > > > > > > The following commit(s) were added to refs/heads/develop by > this > > > > push: > > > > > new f48d105 should we add these generated files? (if not > > > please > > > > > remove) > > > > > f48d105 is described below > > > > > > > > > > commit f48d1051cd2524bc133f96081aa67ba55212bab0 > > > > > Author: Carlos Rovira <carlosrov...@apache.org> > > > > > AuthorDate: Thu Nov 28 16:17:39 2019 +0100 > > > > > > > > > > should we add these generated files? (if not please remove) > > > > > --- > > > > > compiler-jx/src/assembly/compiler-override-scripts/compc | 0 > > > > > compiler-jx/src/assembly/compiler-override-scripts/mxmlc | 0 > > > > > 2 files changed, 0 insertions(+), 0 deletions(-) > > > > > > > > > > diff --git > > > a/compiler-jx/src/assembly/compiler-override-scripts/compc > > > > > b/compiler-jx/src/assembly/compiler-override-scripts/compc > > > > > old mode 100644 > > > > > new mode 100755 > > > > > diff --git > > > a/compiler-jx/src/assembly/compiler-override-scripts/mxmlc > > > > > b/compiler-jx/src/assembly/compiler-override-scripts/mxmlc > > > > > old mode 100644 > > > > > new mode 100755 > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > Carlos Rovira > > > > http://about.me/carlosrovira > > > > > > > > > > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > > -- Carlos Rovira http://about.me/carlosrovira
