Yes. It is. I already committed the changes.

MXRoyale events have some special handling which is why some of the 
functionality is duplicated there.

> On Dec 20, 2019, at 2:45 PM, Carlos Rovira <[email protected]> wrote:
> 
> This seems to me like something that should be located at Core-Basic level.
> Not just at MXRoyale emulation
> 
> El vie., 20 dic. 2019 a las 9:15, Harbs (<[email protected] 
> <mailto:[email protected]>>) escribió:
> 
>> OK
>> 
>>> On Dec 20, 2019, at 9:40 AM, Alex Harui <[email protected] 
>>> <mailto:[email protected]>>
>> wrote:
>>> 
>>> Feel free to do that.  I didn't want to take the time to convert the
>> vars in MouseEvent to getter/setters.
>>> 
>>> On 12/19/19, 11:27 PM, "Harbs" <[email protected] 
>>> <mailto:[email protected]> <mailto:
>> [email protected] <mailto:[email protected]>>> wrote:
>>> 
>>>   Any reason we’re not getting these from the wrappedEvent?
>>> 
>>>> On Dec 20, 2019, at 8:16 AM, [email protected] <mailto:[email protected]> 
>>>> <mailto:
>> [email protected] <mailto:[email protected]>> wrote:
>>>> 
>>>> This is an automated email from the ASF dual-hosted git repository.
>>>> 
>>>> aharui pushed a commit to branch develop
>>>> in repository
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Cb2ddc95767be4c97b12008d7851e00d3%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637124236215825183&amp;sdata=7v2q%2BdpERrh2LeD%2BXZkF6uvn%2BJlnuUroBBG6p7182UA%3D&amp;reserved=0
>>  
>> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Cb2ddc95767be4c97b12008d7851e00d3%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637124236215825183&amp;sdata=7v2q%2BdpERrh2LeD%2BXZkF6uvn%2BJlnuUroBBG6p7182UA%3D&amp;reserved=0>
>> <
>> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Cb2ddc95767be4c97b12008d7851e00d3%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637124236215825183&amp;sdata=7v2q%2BdpERrh2LeD%2BXZkF6uvn%2BJlnuUroBBG6p7182UA%3D&amp;reserved=0
>>  
>> <https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Cb2ddc95767be4c97b12008d7851e00d3%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637124236215825183&amp;sdata=7v2q%2BdpERrh2LeD%2BXZkF6uvn%2BJlnuUroBBG6p7182UA%3D&amp;reserved=0>
>>> 
>>>> 
>>>> commit ad639d7e73b1eb8dc92dd4332ddad3767672d02b
>>>> Author: Alex Harui <[email protected] <mailto:[email protected]>>
>>>> AuthorDate: Thu Dec 19 22:15:29 2019 -0800
>>>> 
>>>>  shiftkey and friends
>>>> ---
>>>> .../MXRoyale/src/main/royale/mx/events/utils/MouseEventConverter.as | 6
>> +++++-
>>>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>>> 
>>>> diff --git
>> a/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/MouseEventConverter.as
>> b/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/MouseEventConverter.as
>>>> index 1340bd5..def4636 100644
>>>> ---
>> a/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/MouseEventConverter.as
>>>> +++
>> b/frameworks/projects/MXRoyale/src/main/royale/mx/events/utils/MouseEventConverter.as
>>>> @@ -186,7 +186,11 @@ package mx.events.utils
>>>>           {
>>>> 
>> Keyboard.setCapsLock(nativeEvent["getModifierState"]("CapsLock"));
>>>>           }
>>>> -            return new mx.events.MouseEvent(nativeEvent["type"],
>> nativeEvent["bubbles"], nativeEvent["cancelable"]);
>>>> +            var event:mx.events.MouseEvent = new
>> mx.events.MouseEvent(nativeEvent["type"], nativeEvent["bubbles"],
>> nativeEvent["cancelable"]);
>>>> +            event.shiftKey = nativeEvent["shiftKey"];
>>>> +            event.ctrlKey = nativeEvent["ctrlKey"];
>>>> +            event.altKey = nativeEvent["altKey"];
>>>> +            return event;
>>>>       }
>>>>   }
>> 
>> 
> 
> -- 
> Carlos Rovira
> http://about.me/carlosrovira <http://about.me/carlosrovira>

Reply via email to