Hi Carlos, I just checked your improvements and those one with columnWidth doesn't work as it should in our use case. I just committed additional example in TourDeJewel which shows that case. Take a look how DataGrid look like in that example.
Thanks, Piotr pon., 9 mar 2020 o 16:42 Carlos Rovira <[email protected]> napisał(a): > Hi Piotr, > > DataGrid now has 3 improvements: > > > - No default width or height > - width and height can be not set or set to pixels or % values > - columnWidths can be no set at all, set all or just some to pixels (I > didn't loo > > Notice that, we don't support % in columns since there's no way to set > columns to percentages. We want to support it?. Maybe we can introduce > "columnPercentWidth" ? Not sure about this > > I'll take a look at the initializer problem with Lists and Dgs. Regarding > this, what's the use case or why you want to change the initializer? having > some kind of example will help me with this, since right now don't know so > much about it. > > Thanks > > Carlos > > > > > > El vie., 6 mar. 2020 a las 17:32, Carlos Rovira (<[email protected] > >) > escribió: > > > I'm thinking that the last problem need a solution like the one in > > ComboBox with passing the IR class to the internal List. > > (Although some issue is still in the mapper infrastructure, but I think > is > > separated issue). > > > > > > El vie., 6 mar. 2020 a las 17:24, Piotr Zarzycki (< > > [email protected]>) escribió: > > > >> Both issues with width/height and this one block migration for now in > our > >> application from Table to DataGrid. I would be the first one who test it > >> for sure when you find cause of that issue and fix it. > >> > >> Thanks for that update, > >> Piotr > >> > >> pt., 6 mar 2020 o 17:17 Carlos Rovira <[email protected]> > >> napisał(a): > >> > >> > Hi Piotr, > >> > > >> > yesterday I saw a strange behaviour with controls that compose list > and > >> > Item renderer changes done recently, but was in ComboBox that can > >> configure > >> > an Item renderer and then pass to the ComboBoxPopUp to its List > internal > >> > component (so we can have custom renderers in ComboBox). In this case > >> > rowCount and rowHeight is not working as expected, sin ce there > >> initializer > >> > is not used in ComboBox internal list, while in VirtualComboBox is > >> working > >> > ok. > >> > I trace the problem to Mappers not update right when the renderers > >> refactor > >> > was done. So while the mapper in Basic adds initializer, in Jewel is > not > >> > doing that. I could not invest more time since I was in the middle of > >> other > >> > fixes, and still had the width/height issues in DG, so could not see > >> > exactly what's the problem. > >> > I want to see if now that this refactor is done is safe to remove > jewel > >> > mappers to user basic versions, but a quick test reveal that is not > >> direct. > >> > In resume, about your problem, I think it could be something like the > >> one > >> > with ComboBox, but need to have the time to reach to that point, > >> hopefully > >> > soon. > >> > Thanks > >> > > >> > >> > >> -- > >> > >> Piotr Zarzycki > >> > >> Patreon: *https://www.patreon.com/piotrzarzycki > >> <https://www.patreon.com/piotrzarzycki>* > >> > > > > > > -- > > Carlos Rovira > > http://about.me/carlosrovira > > > > > > -- > Carlos Rovira > http://about.me/carlosrovira > -- Piotr Zarzycki Patreon: *https://www.patreon.com/piotrzarzycki <https://www.patreon.com/piotrzarzycki>*
