Actually maybe I need to double double-check this more, thanks for the prompt. I will do that now.
On Fri, May 29, 2020 at 12:36 AM Greg Dove <[email protected]> wrote: > > There are a few things like this where it does not. I forget exactly the > rules for that. We are already using this exact same check elsewhere in > bindings code, possibly since its inception. > > On Fri, May 29, 2020 at 12:33 AM Harbs <[email protected]> wrote: > >> I’m surprised that Closure Compiler renaming doesn’t break this. >> >> > On May 28, 2020, at 3:00 PM, Greg Dove <[email protected]> wrote: >> > >> > Alex, >> > >> > I hope you are ok with this change: >> > >> https://github.com/apache/royale-asjs/commit/26d4b9cf7c1968160278754a01bd612946ddf41d >> > >> > >> > It makes a big difference in a large codebase I am working on, many >> > components with bindings that were not working suddenly started working. >> > In the absence of 'this is IBindingClient' I think the '_bindings in >> this' >> > check is as specific as we can get (and very likely faster to execute in >> > any case). >> > >> > Let me know if you have any objections to that, in case I did not >> consider >> > something else that is obvious to you. >> > >> > thanks >> > Greg >> >>
