Hi Edward, I just pushed a change that should solve this via the compiler. In reference to your comments about the tests, that is correct. Originally the tests were only running in debug versions, but I set that up to run as release build by default, so we can capture any issues with compiler changes or other changes that affect minified output. I did not investigate the option to alter the output of the tests for debug vs. release. The easiest way to see the results for the tests is to append '?local' (excluding the quotes) to the url of the tests that failed in the browser and hit refresh. You should have useful information in the console. This should work for both debug and release builds. In both cases you also get clickable stack traces which can help identify the location of the problem, although it is likely easier in the debug builds without the minified code.
On Sat, Jan 2, 2021 at 2:11 AM Carlos Rovira <[email protected]> wrote: > Hi Edward, > > sorry to say that I'm not familiar with the XML and the Royale test suit. > It's clear looking at you PRs that you know much more than me about it. If > you don't have clear how to operate, I hope others can assist here to know > what is better. > > Thanks for your contributions! :) > > > > El vie, 1 ene 2021 a las 13:26, Edward Stangler (<[email protected]>) > escribió: > > > > > Looks like you're getting a problem in the XML.getQName() changes. The > > localName values (from the XML in the tests) are getting errors like > > "Cannot read property 'size' of undefined". > > > > Looking at the JS code of release vs debug, it appears that the compiler > > is not initializing these static variables in release mode (they only > > get initialized in a function that is meant to clear the cache): > > > > static private var _nameMap:Object = Object.create(null); > > static private var _attrNameMap:Object = Object.create(null); > > > > It apparently did work before because it used to be: > > > > static private var _nameMap:Object = {}; > > > > royale-compiler issue #167 seems to be a similar issue. > > > > Should I code a workaround, or is there a compiler fix? > > > > BTW, I had absolutely no idea that there are release-mode and debug-mode > > test runs. (It apparently executes the debug-mode one after > > release-mode fails.) > > > > Would be really nice if their outputs would go to separate directories > > (release-mode test outputs get clobbered by the debug-mode ones). > > > > I just saw the debug-mode test output and, looking at the "out" > > subdirectory, assumed it was the only run. Sorry about that! > > > > > > On 1/1/2021 5:07 AM, Carlos Rovira wrote: > > > Hi, > > > > > > just run ANT build and failed for RELEASE (DEBUG passed): > > > > > > BUILD FAILED > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/build.xml:667: The > > > following error occurred while executing this line: > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/build.xml:134: > > > The following error occurred while executing this line: > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/build.xml:487: > > > The following error occurred while executing this line: > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/XML/build.xml:69: > > > The following error occurred while executing this line: > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/projects/XML/build.xml:73: > > > The following error occurred while executing this line: > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/js/projects/XMLJS/build.xml:54: > > > The following error occurred while executing this line: > > > > > > > > > /Users/carlosrovira/Dev/Royale/Source/royale-asjs/frameworks/js/projects/XMLJS/src/test/royale/build.xml:238: > > > Test Failure > > > > > > RoyaleUnit Release Build Tests must pass: > > > > > > > > > > > > XMLJS.test RoyaleUnit Release build tests: FAILED > > > > > > XMLJS.test RoyaleUnit Debug build tests: PASSED > > > > > > > > > Total time: 5 minutes 35 seconds > > > > > > Error:Build stopped - build SDK with ANT > > > > > > > > > -- > Carlos Rovira > Apache Member & Apache Royale PMC > *Apache Software Foundation* > http://about.me/carlosrovira >
