Chris, I just compiled your last change and everything is ok. Hiedra
-----Mensaje original----- De: Christofer Dutz <christofer.d...@c-ware.de> Enviado el: miércoles, 17 de marzo de 2021 10:14 Para: dev@royale.apache.org Asunto: AW: [MAVEN DISTRIBUTION] getting the Ant and Maven aligned Hi all, Ok .. so, I stripped down the Maven distribution to only contain the jars the Ant version uses. Before that I could see most dependencies related to the royale-maven-plugin pulling in all sorts of Maven dependencies, which clearly aren't needed in the distribution (You don't ship Maven plugins in a distribution ... that just doesn't make sense) I also validated we weren't including stripped-down versions in the maven distribution (Like in the case of Antlr) I did however notice, the Ant version includes commons-lang3 ... we don't have any code (except 2 classes in the compiler tests) that need this library. I didn't force usage of it in the Maven distribution (It could probably also be removed from the Ant distribution ... but no real harm done) Right now, I can't think of anything else needing to be done. So I guess it's up to you folks to test, test, test and start using it. Chris -----Ursprüngliche Nachricht----- Von: Christofer Dutz <christofer.d...@c-ware.de> Gesendet: Mittwoch, 17. März 2021 09:46 An: dev@royale.apache.org Betreff: AW: [MAVEN DISTRIBUTION] getting the Ant and Maven aligned Hi all, So, I guess the last optimization I know I could do, would be to exclude unneeded jars. I know the number of jars in the ANT build's "external" directory is a lot less than the Maven version. I guess Maven just adds all transitive dependencies, no matter if the used code-paths actually use them. This would even reduce the size of the SDK. Chris -----Ursprüngliche Nachricht----- Von: Maria Jose Esteve <mjest...@iest.com> Gesendet: Dienstag, 16. März 2021 18:23 An: dev@royale.apache.org Betreff: RE: [MAVEN DISTRIBUTION] getting the Ant and Maven aligned Well, I already have it clear ... The errors that I am receiving do not have to do with the distribution but with the modifications that I have had to make due to the <mx: Array> error, the inclusion of <skipAS> true </skipAS> and the elimination of the folder ". m2 / com / ... myproject / .. "on the PC where I am testing the distribution generate dependency errors because before the arqs were generated. Swf.swc and js.swc and not now. What a mess right? LOL As the errors have to do with the issue "<mx: Array>" I will detail it there so as not to create more confusion. @Chris, I think I need to do a test: modify the sdk and see if the changes take me, I remember that I also had problems with this ... I tell you things. Hiedra. -----Mensaje original----- De: Maria Jose Esteve Enviado el: martes, 16 de marzo de 2021 17:11 Para: dev@royale.apache.org Asunto: RE: [MAVEN DISTRIBUTION] getting the Ant and Maven aligned Hahahaha, I haven't detailed anything because I haven't seen them in depth yet and I don't want to waste your time. Although I know that the errors have to do with the distribution, since they do not occur with the normal compilation, I am not sure if they originate from this. Soon I will tell you more things. Hiedra. -----Mensaje original----- De: Christofer Dutz <christofer.d...@c-ware.de> Enviado el: martes, 16 de marzo de 2021 17:03 Para: dev@royale.apache.org Asunto: AW: [MAVEN DISTRIBUTION] getting the Ant and Maven aligned Hi Hiedra, could you please explain what's not working for that project? I can't quite see in your email that it's not working. Chris -----Ursprüngliche Nachricht----- Von: Maria Jose Esteve <mjest...@iest.com> Gesendet: Dienstag, 16. März 2021 16:58 An: dev@royale.apache.org Betreff: RE: [MAVEN DISTRIBUTION] getting the Ant and Maven aligned I'm glad too 😝 hahahaha. Thank you for your work. "I still do not give you 100% 😝 because the large project does not compile with the distribution" and yes with the compilation without distribution ... Surely there is something that I have to put differently ... I'll keep you informed. Hiedra -----Mensaje original----- De: Christofer Dutz <christofer.d...@c-ware.de> Enviado el: martes, 16 de marzo de 2021 16:36 Para: dev@royale.apache.org Asunto: AW: [MAVEN DISTRIBUTION] getting the Ant and Maven aligned Hi Hiedra, happy that it worked for you ... in general people were complaining that the Maven distribution wasn't "working" for them. This was in various situations and IDEs ... so what I did, was to try to change the maven distribution to me more like the one produced by Ant, generally allowing us to use the Maven-built distribution for download. Chris -----Ursprüngliche Nachricht----- Von: Maria Jose Esteve <mjest...@iest.com<mailto:mjest...@iest.com>> Gesendet: Dienstag, 16. März 2021 16:08 An: dev@royale.apache.org<mailto:dev@royale.apache.org> Betreff: RE: [MAVEN DISTRIBUTION] getting the Ant and Maven aligned Hi, I have had a difficult few weeks with work, I feel the silence. First I wanted to remember that my environment and routines I think are a little different from Piotr's, maybe someone is in the same situation: - IDE: vsCode - Maven royale-compiler, royale-typedefs and royale-asjs compilation, js only. - I compile the projects with maven: mvn clean install -Droyalelib=${env:ROYALE_HOME}\\frameworks Env:ROYALE_HOME --> sdk distribution folder In the pom.xml / -compiler.exclude-defaults-css-files=MXRoyale-0.9.8-SNAPSHOT-js.swc:defaults.css; - Test projects: Jewel application. Project Ex. 1: Royale-Echarts [1] - targets: JSRoyale Project Ex. 2: AppWithLib [2] && Simplelib [3] - targets: JSRoyale Project Ex. 3: Custom app. - Jewel application - crux and mx.rpc.remoting.RemoteObject - project consisting of an app project (views) and an external library - JSRoyale (classes, controllers, models and delegates) Project Ex. 4: Custom app. - Jewel application - crux and mx.rpc.remoting.RemoteObject - This project is not my belief, the framework was created by some external collaborators. It is made up of a royale-app and a royale-libs composed of several interconnected libraries and of these with the royale-app. In royale-app as expected, the views, and in royale-libs all the rest of the code (general classes, custom components, echarts [1], controllers, models and delegates) The application is compiled with the JSRoyale target and the libraries are compiled in js and swf (I can't understand this because the target is also JSRoyale) [1] https://github.com/mjesteve/Royale-ECharts/tree/develop_v5 [2] https://github.com/mjesteve/royale-asjs/tree/Example_AppWithLib/examples/crux/AppWithLib [3] https://github.com/mjesteve/royale-asjs/tree/Example_AppWithLib/examples/crux/SampleLib @Chris, I have generated the distribution to the second 😝, had always used "-P with-distribution" (with white space between the "-P" and the "w") but now it does not recognize me. Yes I was recognized by "-Pwith-distribution" --> Ok all Although I do not use the mvn swf-js distribution, I have also compiled it and generated it correctly. I don't know what should be generated with the distribution to be considered "aligned with the ant distribution" but in the "themes" folder, of the swf-js distribution, the "Halo" folder is missing and I don't know if anything else is there? should it be generated? The IDE perfectly recognizes both distributions. Successful mvn compilation of "Project Ex. 1", "Project Ex. 2" and "Project Ex. 3" but with "Project Ex. 4" I get errors that I am debugging right now and that I will share with you in a bit. I have to say that all "Projects Ex." compile without errors if I use the compiled SDK "no distribution" Hiedra -----Mensaje original----- De: Piotr Zarzycki <piotrzarzyck...@gmail.com<mailto:piotrzarzyck...@gmail.com>> Enviado el: lunes, 15 de marzo de 2021 13:39 Para: Apache Royale Development <dev@royale.apache.org<mailto:dev@royale.apache.org>> Asunto: Re: [MAVEN DISTRIBUTION] getting the Ant and Maven aligned Hi Chris, I have tested your changes and finally I'm able build project using generated distribution. I would like to test it for couple of days to see if I won't have any problems with Josh's language server and we should be good here. Thanks, Piotr sob., 13 mar 2021 o 15:10 Christofer Dutz <christofer.d...@c-ware.de<mailto:christofer.d...@c-ware.de<mailto:christofer.d...@c-ware.de%3cmailto:christofer.d...@c-ware.de>>> napisał(a): > Hi Piotr, > > ok ... that was easily fixable. > In one of my last commits I had removed the class path entry to > antlr-runtime.jar as the Ant one didn't have this. > But the missing class you reported is in this jar. > > So, I compared the antlr.jar in the Ant and Maven distribution. They > were > greatly different in size (Ant:2,4MB vs Maven 0.4MB) > I therefore re-added the antlr-rutime.jar back to the class path of > the > Maven distribution. > > This error should now disappear. > > Chris >…
