Just a quick comment:
This thread was started in relation to the Maven ci Build. But I don't see
any lingering issues with that.
I think the lingering issues are with the ant build on the server that also
runs our royaleunit tests. And the issue there seems to be that the Google
closure lib is too recent... there are errors related to use of es6 const
declarations and other es6 features being used in the Google closure js lib
files (see excerpt example [1] below), and I assume we should be using and
older es5 version. But I don't know specifically if this is the cause of
the test failures or not.
1.
SEVERE: goog/log/log.js:870: ERROR - This language feature is only
supported for ECMASCRIPT6 mode or better: const declaration.
[mxmlc] const indexOfHandler = loggerEntry.handlers.indexOf(h
andler);
On Fri, 7 Jan 2022, 5:21 am Yishay Weiss, <[email protected]> wrote:
> >I would try to watch the tests run via Remote Desktop and see if you see
> any clues on the screen.
>
> No clues. Looks like it’s frozen until it times out.
>
> > I think sometimes an early fatal error can prevent anything being
> written to the socket. Or maybe killing FF processes left the socket
> locked.
>
> I restarted and it still happens, so not sure what’s going on. I’ll try
> again when I get some time.
>
> From: Alex Harui<mailto:[email protected]>
> Sent: Monday, January 3, 2022 7:30 PM
> To: [email protected]<mailto:[email protected]>
> Subject: Re: [MAVEN-BUILD] Royale » Royale-asjs - Build # 2015 - Still
> Failing!
>
> OK, Assuming the job you got it from is passing and had the updated files,
> then I think to debug socket failures I would try to watch the tests run
> via Remote Desktop and see if you see any clues on the screen. I think
> sometimes an early fatal error can prevent anything being written to the
> socket. Or maybe killing FF processes left the socket locked.
>
> HTH,
> -Alex
>
> On 1/2/22, 11:58 PM, "Yishay Weiss" <[email protected]> wrote:
>
> “latest” is incorrect. I copied the closure lib I was seeing in one of
> the other builds. Don’t remember which exactly. I diffed with [1] and could
> only see EOL diffs so it might be that. I suppose I could have just removed
> the GOOG_HOME env var for that build and added a super-clean to be safer,
> but I wasn’t sure if that would work, plus I have seen jobs that depend on
> other jobs leaving stuff on the file system and I wasn’t sure if
> super-clean might mess with that (as I think you had suggested).
>
> [1]
> C:\jenkins\workspace\royale-compiler-integration-tests\compiler-jx\target\junit-temp\bin\js-debug\library\closure
>
> From: Alex Harui<mailto:[email protected]>
> Sent: Monday, January 3, 2022 9:10 AM
> To: [email protected]<mailto:[email protected]>
> Subject: Re: [MAVEN-BUILD] Royale » Royale-asjs - Build # 2015 - Still
> Failing!
>
> What do you mean by "latest GC lib?" IIRC, we are using an old one,
> actually a subset of that old one. There is no guarantee a later one will
> work. I think I got burned by dependencies on certain versions of Closure
> Compiler in the past. I think frameworks/downloads.xml has the URL for the
> Closure Library version.
>
> If you can log into the CI server when the build is going on, you can
> sometimes see other error output when there are failures.
>
> HTH,
> -Alex
>
> On 1/2/22, 5:08 AM, "Yishay Weiss" <[email protected]> wrote:
>
> I removed it. The problem was that it was getting GC from an env
> var, so I updated the GOOG_HOME location to include the latest GC lib.
>
> However, we are now getting a socket timeout
>
>
>
> C:\jenkins\workspace\royale-asjs_jsonly\frameworks\js\projects\BasicJS\src\test\royale\build.xml:211:
> java.util.concurrent.ExecutionException: Socket timeout waiting for
> royaleunit report
>
> at
> java.util.concurrent.FutureTask.report(FutureTask.java:122)
>
> at java.util.concurrent.FutureTask.get(FutureTask.java:192)
>
> at
> org.apache.royale.test.ant.tasks.TestRun.run(TestRun.java:77)
>
> at
> org.apache.royale.test.ant.tasks.RoyaleUnitTask.execute(RoyaleUnitTask.java:192)
>
>
> From: Yishay Weiss<mailto:[email protected]>
> Sent: Sunday, January 2, 2022 9:31 AM
> To: [email protected]<mailto:[email protected]>
> Subject: RE: [MAVEN-BUILD] Royale » Royale-asjs - Build # 2015 -
> Still Failing!
>
> I just added super-clean to the beginning of the job. Let’s see
> what happens.
>
> From: Alex Harui<mailto:[email protected]>
> Sent: Wednesday, December 29, 2021 10:20 AM
> To: [email protected]<mailto:[email protected]>
> Subject: Re: [MAVEN-BUILD] Royale » Royale-asjs - Build # 2015 -
> Still Failing!
>
> Oh, sorry, the subject said "Maven-build".
>
> For Ant, I looked and saw that the workspace is not deleted in the
> royale-asjs jobs before each build. I don't remember why we do that (maybe
> just speed, might be some downloaded/cached dependencies) but that means we
> need to find some other way to delete the js/lib/closure-library folder so
> that the frameworks/downloads.xml will unzip Closure Library again and grab
> a different subset of the files.
>
> We can add the "super-clean" or just log into the server and
> delete that folder. I'm not sure why compiler uses `wipe-all`, typedefs
> uses 'wipe' and asjs uses 'super-clean' to essentially do the same thing.
>
> HTH,
> -Alex
>
> On 12/29/21, 12:04 AM, "Yishay Weiss" <[email protected]>
> wrote:
>
> But this is ant unless I’m missing something.
>
> From: Alex Harui<mailto:[email protected]>
> Sent: Wednesday, December 29, 2021 9:59 AM
> To: [email protected]<mailto:[email protected]>
> Subject: Re: [MAVEN-BUILD] Royale » Royale-asjs - Build # 2015
> - Still Failing!
>
> I pushed a change a couple of hours ago that sets the closure
> library files for Maven.
>
> -Alex
>
> On 12/28/21, 11:11 PM, "Yishay Weiss" <[email protected]>
> wrote:
>
> Is this [1] what you meant? Just ran that.
>
> [1] PS C:\jenkins\workspace\royale-compiler> ant wipe-all
>
> From: Harbs<mailto:[email protected]>
> Sent: Tuesday, December 28, 2021 2:59 PM
> To: Apache Royale Development<mailto:[email protected]
> >
> Subject: Re: [MAVEN-BUILD] Royale » Royale-asjs - Build #
> 2015 - Still Failing!
>
> We probably need to wipe closure on the server.
>
> > On Dec 28, 2021, at 2:45 PM, Yishay Weiss <
> [email protected]> wrote:
> >
> > As far as I can tell it’s failing in ant [1] as well
> >
> > [1] royale-asjs_jsonly #3916 Console [Jenkins] (
> azure.com)<
> https://nam04.safelinks.protection.outlook.com/?url=http%3A%2F%2Fapacheroyaleci2.westus2.cloudapp.azure.com%3A8080%2Fjob%2Froyale-asjs_jsonly%2F3916%2FconsoleFull&data=04%7C01%7Caharui%40adobe.com%7C591d22beb5814245875708d9ce8eaf82%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637767934963865030%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=C%2FaJViMvvs%2FU8hzi3azSrJZ495L0%2Bqv2xopEzpM%2BOQE%3D&reserved=0
> >
> >
> > From: Harbs<mailto:[email protected]>
> > Sent: Tuesday, December 28, 2021 1:20 PM
> > To: Apache Royale Development<mailto:
> [email protected]>
> > Subject: Re: [MAVEN-BUILD] Royale » Royale-asjs - Build
> # 2015 - Still Failing!
> >
> > It’s still failing to get the google closure files in
> Maven. It works in Ant. No idea how to fix this...
> >
> >> On Dec 28, 2021, at 12:55 PM, [email protected]
> wrote:
> >>
> >> Royale » Royale-asjs - Build # 2015 - Still Failing:
> >>
> >> Check console output at
> https://nam04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fci-builds.apache.org%2Fjob%2FRoyale%2Fjob%2FRoyale-asjs%2F2015%2F&data=04%7C01%7Caharui%40adobe.com%7C591d22beb5814245875708d9ce8eaf82%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C637767934963865030%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Y%2Bot0sCLTcpyXSm%2Fny%2B%2FX%2BB%2FWqygkg9uTqgFOBi1PeU%3D&reserved=0
> to view the results.
> >
>
>
>
>
>
>