While I was having lunch, I thought of another reason why I'm not inclined to vote for a build where the approval script doesn't pass.
In the past, sometimes, the Royale CI server went over a week at a time with no successful builds. We're much better about fixing it quickly these days. Back then, on multiple occasions, I took on the effort to fix it, and after taking care of the original issue, I discovered that the build was still broken. I turned out that later commits had issues too, and no one noticed because the build was already failing. With the approval script, I worry that an issue may not get fixed after we release, and then, when the next release rolls around, we have to again choose whether to fix it or not. So it might get delayed again. If that happens, we won't know if additional issues are building up behind the original one, which makes it even harder to fix the approval script, and we may end up missing more serious issues that the approval script could have caught for us. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Wed, May 10, 2023 at 12:22 PM Josh Tynjala <joshtynj...@bowlerhat.dev> wrote: > I'm inclined to vote -1 if the approval script ever fails on an RC. I > could be convinced to vote 0 at best, if I'm feeling particularly confident > about everything else. It just feels to me like the script should be able > to pass as a bare minimum. Maybe if it were easy to skip the part that > fails and continue to the end, but I hate to be left wondering if there > were additional issues after the one that caused the failure. > > I'll check the designmodo requirement later today. > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Wed, May 10, 2023 at 11:48 AM Yishay Weiss <yishayj...@hotmail.com> > wrote: > >> The reason I thought it was not a blocker was because I assumed the ant >> script for TDJ had never been functional. I can see now that there was >> likely regression due to e71b1485cce885f84cda7d7883750eebeec38b3d which was >> one day after our prior release. I am not sure why my TDJ test was >> successful before my latest commit. Maybe the themes had been built >> previously or I was running it from a different directory. Anyway, I'll try >> to fix that. Thanks for the input, Josh and Piotr. >> >> I do think we should consider whether this type of regression necessarily >> implies no release. What do other folks think? >> >> Has anybody confirmed Maria's issues with designmodo fonts being >> obligatory? >> ________________________________ >> From: Josh Tynjala <joshtynj...@bowlerhat.dev> >> Sent: Wednesday, May 10, 2023 7:17 PM >> To: dev@royale.apache.org <dev@royale.apache.org> >> Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3 >> >> I'm getting the same failure when running the approval script. I won't be >> able to vote +1 for this RC. >> >> Since the themes are incorrectly building with TourDeJewel as the basedir, >> I'm guessing that the theme targets in TourDeJewel/build.xml need the dir >> attribute specified in the <ant/> element: >> >> Before: >> >> <ant >> >> antfile="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme/build.xml"/> >> >> After: >> >> <ant >> dir="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme" >> >> antfile="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme/build.xml"/> >> >> Be sure to test it, though. That's just a guess. >> >> -- >> Josh Tynjala >> Bowler Hat LLC <https://bowlerhat.dev> >> >> >> On Wed, May 10, 2023 at 3:09 AM Yishay Weiss <yishayj...@hotmail.com> >> wrote: >> >> > Looks like TDJ ant build is still failing... I don't think it's a >> blocker. >> > ________________________________ >> > From: Piotr Zarzycki <piotrzarzyck...@gmail.com> >> > Sent: Wednesday, May 10, 2023 12:21 PM >> > To: dev@royale.apache.org <dev@royale.apache.org> >> > Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3 >> > >> > Hello, >> > >> > I was trying to vote. I got following error during build ant non-swf. >> > Anyone have same issue ? I'm on Mac OSX Ventura 13.3.1 (a) >> > >> > compile: >> > >> > Compiling libs/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc >> > >> > ROYALE_HOME: >> > >> > >> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs >> > >> > ROYALE_SWF_COMPILER_HOME: >> > >> > >> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs >> > >> > ROYALE_COMPILER_HOME: >> > >> > >> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/js >> > >> > args: >> > >> > >> > >> +royalelib=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks >> > >> > +playerglobal.version=11.1 >> > >> > >> > >> +env.AIR_HOME=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs >> > >> > -compiler.strict-xml=true >> > >> > -compiler.targets=SWF,JSRoyale >> > >> > >> > >> -output=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/target/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc >> > >> > >> > >> -load-config=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/src/main/config/compile-swf-config.xml >> > >> > >> > >> -js-load-config=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks/js-config.xml >> > >> > >> > >> -js-load-config+=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/../../js/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-ThemeJS/src/main/config/compile-js-config.xml >> > >> > 0.225995245 seconds >> > >> > command line unable to open >> > >> > >> '/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/src/main/config/compile-swf-config.xml'. >> > >> > >> > Java Result: 4 >> > >> > >> > compile-js: >> > >> > >> > copy-swc: >> > >> > >> > BUILD FAILED >> > >> > >> > >> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/ApproveRoyale.xml:795: >> > The following error occurred while executing this line: >> > >> > >> > >> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/build.xml:688: >> > The following error occurred while executing this line: >> > >> > >> > >> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/build.xml:101: >> > The following error occurred while executing this line: >> > >> > >> > >> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/build.xml:45: >> > The following error occurred while executing this line: >> > >> > >> > >> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/build.xml:387: >> > The following error occurred while executing this line: >> > >> > >> > >> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme/build.xml:56: >> > Warning: Could not find file >> > >> > >> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/target/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc >> > to copy. >> > >> > >> > >> > >> > wt., 9 maj 2023 o 19:21 Yishay Weiss <yishayj...@hotmail.com> >> napisał(a): >> > >> > > This is the discussion thread. >> > > >> > >> > >> > -- >> > >> > Piotr Zarzycki >> > >> >
