Thanks
________________________________
From: cont...@cristallium.com <cont...@cristallium.com>
Sent: Friday, May 12, 2023 1:02 PM
To: dev@royale.apache.org <dev@royale.apache.org>
Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
Hi all,
If it may help : I have just downloaded 0.9.10 RC4
run "ant all" and set "y" for the question "Do you want to install the
designmodo fonts? (y, [n])"
=> Compilation is fine :
all:
BUILD SUCCESSFUL
Total time: 10 minutes 5 seconds
Then I launch VisualStudio at
"0.9.10-rc4\royale-asjs\examples\jewel\TourDeJewel" folder
Add .vscode folder with launch.json,settings.json,tasks.json, then set
SDK to 0.9.10 RC4 and run compilation, all seems OK :
MXMLJSC
+royalelib=d:\dev\Royale\0.9.10-rc4\royale-asjs\frameworks
--debug=true
+configname=royale
--targets=JSRoyale
--source-path+=src/main/resources
--source-map=true
--html-template=src/main/resources/jewel-example-index-template.html
--theme=${royalelib}/themes/JewelTheme/src/main/resources/defaults.css
-js-dynamic-access-unknown-members=true
--
src/main/royale/App.mxml
The project 'App' has been successfully compiled.
15.5849618 seconds
* Terminal will be reused by tasks, press any key to close it.
Le 2023-05-12 11:13, Maria Jose Esteve a écrit :
> Yes, I understand that, but "until now" ALWAYS, ALWAYS, even if I
> hadn't changed the sass file, defaults.css files were generated and
> "apparently" they were different because it presented them to me to
> upload them to the repo. This has happened to me in every SDK build
> since I included the "option-with-sass-compile" profile.
>
> I just wanted to give you some explanation for this behavior.
>
> By the way,... forgive me if this is a simple question... I compile TDJ
> fine, I don't see errors what are those errors you are talking about in
> the previous emails? 😝
>
> Hiedra
>
> -----Mensaje original-----
> De: Yishay Weiss <yishayj...@hotmail.com>
> Enviado el: viernes, 12 de mayo de 2023 10:12
> Para: dev@royale.apache.org
> Asunto: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> Has the sass file changed? If not, I expect the defaults.css files
> won't change either.
> ________________________________
> From: Maria Jose Esteve <mjest...@iest.com>
> Sent: Friday, May 12, 2023 10:36 AM
> To: dev@royale.apache.org <dev@royale.apache.org>
> Subject: RE: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> I am compiling Theme but the generated files are not showing up as
> "modified" so I can upload them to the repo.... has something changed
> in the compilation scripts?
>
> Let me explain a little more...
> Until now, ALWAYS when I compiled the SDK, the defaults.css files were
> generated, and I could see them in the "github desktop" as modified. I
> have not changed anything in my compilation bat but, now, these files
> are not presented as modified....
>
> Does this happen to anyone else?
> This is my Maven compile statement [1]
>
> [1] mvn clean install -DskipTests -P
> option-with-sass-compile,option-with-swf -Drat.skip=true
>
> Hiedra
>
> -----Mensaje original-----
> De: Yishay Weiss <yishayj...@hotmail.com> Enviado el: jueves, 11 de
> mayo de 2023 17:21
> Para: dev@royale.apache.org
> Asunto: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
>> The Approval script finishes successfully for me after reverting the
>> changes in TDJ build.
>
> Locally, I'm waiting for Maria to make the commits, perhaps with other
> necessary changes.
> ________________________________
> From: Yishay Weiss <yishayj...@hotmail.com>
> Sent: Thursday, May 11, 2023 6:19 PM
> To: dev@royale.apache.org <dev@royale.apache.org>
> Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> The Approval script finishes successfully for me after reverting the
> changes in TDJ build.
> ________________________________
> From: Yishay Weiss <yishayj...@hotmail.com>
> Sent: Thursday, May 11, 2023 3:48 PM
> To: dev@royale.apache.org <dev@royale.apache.org>
> Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> Hi Maria,
>
> After trying to fix this myself I have come to the conclusion that
> there is no easy fix and we just need to revert the changes you made in
> 33a58b54da69d2e10fb69782a51dfbc6fdeed628 and
> e71b1485cce885f84cda7d7883750eebeec38b3d
>
> I now recall that Carlos never enabled theme building in ant for lack
> of a dedicated task. The log history shows that instead, the
> defaults.css were being manually updated after each sass change (I
> guess by running the mvn build) and copying the output to src. That
> includes css files for themes and for TDJ.
>
> I suggest we continue operating in that way until we find a decent way
> build sass with ant.
>
> Maybe with this Apache licensed Java solution [1] we can one day build
> our own ant task and use it in our build. However, I doubt that's a
> priority, and I would only consider doing it for 0.9.11 or higher.
>
> If you agree with this, feel free to revert your said changes on dev
> and I'll start another RC after that.
>
> Thanks
>
> [1] cathive/sass-java: Libsass for Java
> (github.com)<https://github.com/cathive/sass-java>
> [https://opengraph.githubassets.com/58ec07301dcc16ec89377a755fa4f204342b52fb5ca2c58285d8accff5ca06b1/cathive/sass-java]<https://github.com/cathive/sass-java>
> GitHub - cathive/sass-java: Libsass for
> Java<https://github.com/cathive/sass-java>
> Libsass for Java. Contribute to cathive/sass-java development by
> creating an account on GitHub.
> github.com
>
> ________________________________
> From: Maria Jose Esteve <mjest...@iest.com>
> Sent: Thursday, May 11, 2023 2:55 PM
> To: dev@royale.apache.org <dev@royale.apache.org>
> Subject: RE: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> Yes, I don't know if I got confused when I moved it or it was because
> of my system.
> In my last tests it said "n" and it worked for me, sorry for the noise.
>
> On the other hand, I have seen that the compilation of the Jewel Themes
> are not being done, there are errors, I will look at it this afternoon
> to see if I can fix it. I do it in the develop branch right?
>
> Hiedra
>
> -----Mensaje original-----
> De: Yishay Weiss <yishayj...@hotmail.com> Enviado el: jueves, 11 de
> mayo de 2023 10:29
> Para: dev@royale.apache.org
> Asunto: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> I also chose 'no' for designmodo and it's running for me so far
> (waiting for the TDJ fail).
> ________________________________
> From: Maria Jose Esteve <mjest...@iest.com>
> Sent: Thursday, May 11, 2023 1:40 AM
> To: dev@royale.apache.org <dev@royale.apache.org>
> Subject: RE: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> Really?... maybe I did something wrong? Now I'll see.
>
> Hiedra
>
> -----Mensaje original-----
> De: Josh Tynjala <joshtynj...@bowlerhat.dev> Enviado el: miércoles, 10
> de mayo de 2023 22:25
> Para: dev@royale.apache.org
> Asunto: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> On my machine, I can answer "n" to download the designmodo fonts, and
> the build continues (failing at the same TourDeJewel example as when I
> answer "y" instead).
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
> On Wed, May 10, 2023 at 11:48 AM Yishay Weiss <yishayj...@hotmail.com>
> wrote:
>
> The reason I thought it was not a blocker was because I assumed the
> ant script for TDJ had never been functional. I can see now that there
> was likely regression due to e71b1485cce885f84cda7d7883750eebeec38b3d
> which was one day after our prior release. I am not sure why my TDJ
> test was successful before my latest commit. Maybe the themes had been
> built previously or I was running it from a different directory.
> Anyway, I'll try to fix that. Thanks for the input, Josh and Piotr.
>
> I do think we should consider whether this type of regression
> necessarily implies no release. What do other folks think?
>
> Has anybody confirmed Maria's issues with designmodo fonts being
> obligatory?
> ________________________________
> From: Josh Tynjala <joshtynj...@bowlerhat.dev>
> Sent: Wednesday, May 10, 2023 7:17 PM
> To: dev@royale.apache.org <dev@royale.apache.org>
> Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> I'm getting the same failure when running the approval script. I won't
> be able to vote +1 for this RC.
>
> Since the themes are incorrectly building with TourDeJewel as the
> basedir, I'm guessing that the theme targets in TourDeJewel/build.xml
> need the dir attribute specified in the <ant/> element:
>
> Before:
>
> <ant
>
> antfile="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Empha
> sized-Amethyst-Theme/build.xml"/>
>
> After:
>
> <ant
> dir="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme"
>
> antfile="${basedir}/../../../frameworks/themes/Jewel-Dark-NoFlat-Empha
> sized-Amethyst-Theme/build.xml"/>
>
> Be sure to test it, though. That's just a guess.
>
> --
> Josh Tynjala
> Bowler Hat LLC <https://bowlerhat.dev>
>
> On Wed, May 10, 2023 at 3:09 AM Yishay Weiss <yishayj...@hotmail.com>
> wrote:
>
> Looks like TDJ ant build is still failing... I don't think it's a
> blocker. ________________________________
> From: Piotr Zarzycki <piotrzarzyck...@gmail.com>
> Sent: Wednesday, May 10, 2023 12:21 PM
> To: dev@royale.apache.org <dev@royale.apache.org>
> Subject: Re: [DISCUSS] Release Apache Royale 0.9.10 RC3
>
> Hello,
>
> I was trying to vote. I got following error during build ant non-swf.
> Anyone have same issue ? I'm on Mac OSX Ventura 13.3.1 (a)
>
> compile:
>
> Compiling libs/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc
>
> ROYALE_HOME:
>
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/ap
> ache-royale-0.9.10-src/royale-asjs
> ROYALE_SWF_COMPILER_HOME:
>
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/ap
> ache-royale-0.9.10-src/royale-asjs
> ROYALE_COMPILER_HOME:
>
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/ap
> ache-royale-0.9.10-src/royale-asjs/js
> args:
>
> +royalelib=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/roy
> +ale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks
> +playerglobal.version=11.1
>
> +env.AIR_HOME=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/
> +royale_vote/apache-royale-0.9.10-src/royale-asjs
> -compiler.strict-xml=true
>
> -compiler.targets=SWF,JSRoyale
>
> -output=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale
> _vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/
> target/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc
>
> -load-config=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/r
> oyale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJ
> ewel/src/main/config/compile-swf-config.xml
>
> -js-load-config=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SD
> K/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks/js-confi
> g.xml
>
> -js-load-config+=/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_S
> -js-load-config+DK/royale_vote/apache-royale-0.9.10-src/royale-asjs/ex
> -js-load-config+amples/jewel/TourDeJewel/../../js/themes/Jewel-Dark-No
> -js-load-config+Flat-Emphasized-Amethyst-ThemeJS/src/main/config/compi
> -js-load-config+le-js-config.xml
> 0.225995245 seconds
>
> command line unable to open
>
> '/Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/src/main/config/compile-swf-config.xml'.
>
> Java Result: 4
>
> compile-js:
>
> copy-swc:
>
> BUILD FAILED
>
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/ApproveRoyale.xml:795:
> The following error occurred while executing this line:
>
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/build.xml:688:
> The following error occurred while executing this line:
>
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/build.xml:101:
> The following error occurred while executing this line:
>
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/build.xml:45:
> The following error occurred while executing this line:
>
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/build.xml:387:
> The following error occurred while executing this line:
>
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/apache-royale-0.9.10-src/royale-asjs/frameworks/themes/Jewel-Dark-NoFlat-Emphasized-Amethyst-Theme/build.xml:56:
> Warning: Could not find file
>
> /Users/piotrzarzycki/Downloads/MoonshineSDKs/Royale_SDK/royale_vote/ap
> ache-royale-0.9.10-src/royale-asjs/examples/jewel/TourDeJewel/target/J
> ewel-Dark-NoFlat-Emphasized-Amethyst-Theme.swc to copy.
>
> wt., 9 maj 2023 o 19:21 Yishay Weiss <yishayj...@hotmail.com>
> napisał(a):
> This is the discussion thread.
>
> --
>
> Piotr Zarzycki
