Now that I've had my morning tea, I remember now that I put RoyaleUnit's dependencies into a separate directory so that they don't conflict with anything else (and so that they aren't loaded by the compiler when they aren't needed). I didn't know that I needed to update ApproveRoyale.xml. I will get that fixed for *future* releases.
For now, this is just a minor issue, and it should not prevent you from voting in favor of this RC. The license is actually allowed, but "Rat" incorrectly flags it. The approval script will not fail when it mentions this license, so we don't need to do anything to fix it immediately. -- Josh Tynjala Bowler Hat LLC <https://bowlerhat.dev> On Mon, May 15, 2023 at 8:55 AM Josh Tynjala <joshtynj...@bowlerhat.dev> wrote: > The approval script excludes dom4j-LICENSE.txt at the following location: > > <exclude name="royale-asjs/js/lib/dom4j-LICENSE.txt"/> > > But your path is slightly different: > > royale-asjs/js/lib/royaleunit/dom4j-LICENSE.txt > > I think we can just make a minor tweak to the approval script to add this > path too: > > <exclude name="royale-asjs/js/lib/royaleunit/dom4j-LICENSE.txt"/> > > -- > Josh Tynjala > Bowler Hat LLC <https://bowlerhat.dev> > > > On Sat, May 13, 2023 at 6:29 PM Maria Jose Esteve <mjest...@iest.com> > wrote: > >> Hi, >> I keep testing the automated compilation option [1] the compilation gave >> me error ☹. >> I have left the log of the compilation here [2] but I attach the error: >> >> <<<<<<< >> ... >> main: >> Copying 1 file to >> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src\royale-asjs\examples\native\USStatesMap\bin\js-debug >> Copying 1 file to >> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\apache-royale-0.9.10-src\royale-asjs\examples\native\USStatesMap\bin\js-release >> >> main: >> >> build_maven: >> Path is C:\Program Files (x86)\Common >> Files\Oracle\Java\javapath;D:\Apache;C:\Program >> Files\Java\jdk1.8.0_281\bin;D:\Apache\apache-ant-1.10.13\bin;D:\Apache\apache-maven-3.9.1\bin;D:\app\client\hiedra\product\19.0.0\client_1\bin;C:\Windows\system32;C:\Windows;C:\Windows\System32\Wbem;C:\Windows\System32\WindowsPowerShell\v1.0\;C:\Windows\System32\OpenSSH\;C:\Program >> Files (x86)\NVIDIA Corporation\PhysX\Common;C:\Program >> Files\dotnet\;C:\WINDOWS\system32;C:\WINDOWS;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32\WindowsPowerShell\v1.0\;C:\WINDOWS\System32\OpenSSH\;C:\Program >> Files\Git\cmd;C:\Users\hiedra\AppData\Local\Programs\Microsoft VS >> Code;C:\Program Files\Microsoft SQL Server\Client >> SDK\ODBC\170\Tools\Binn\;C:\Program >> Files\PowerShell\7-preview\preview;C:\Program Files >> (x86)\Yarn\bin\;D:\Apache\HaxeToolkit\haxe;D:\Apache\HaxeToolkit\neko;C:\Program >> Files\nodejs\;C:\Program Files (x86)\Intel\Intel(R) Management Engine >> Components\DAL;C:\Program Files\Intel\Intel(R) Management Engine >> Components\DAL;C:\Program Files (x86)\Pulse >> Secure\VC142.CRT\X64\;C:\Program Files (x86)\Pulse >> Secure\VC142.CRT\X86\;C:\Program Files\Microsoft SQL >> Server\150\Tools\Binn\;C:\Program Files\Microsoft SQL >> Server\130\Tools\Binn\;C:\Program Files >> (x86)\GnuPG\bin;C:\Users\hiedra\AppData\Local\Microsoft\WindowsApps;C:\Users\hiedra\AppData\Local\GitHubDesktop\bin;C:\Users\hiedra\.dotnet\tools;C:\Users\hiedra\AppData\Local\Microsoft\WindowsApps;C:\Users\hiedra\AppData\Local\Programs\Microsoft >> VS >> Code\bin;C:\Users\hiedra\AppData\Local\Yarn\bin;C:\Users\hiedra\AppData\Roaming\npm >> >> BUILD FAILED >> >> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:796: The >> following error occurred while executing this line: >> >> D:\Develop_Royale\Projects\Royale-SDK\0.9.10\ApproveRoyale.xml:809: exec >> returned: 1 >> >> Total time: 39 minutes 52 seconds >> >>>>>>> >> >> The error occurs in the Maven compilation task (it's in the path, could >> it be because of the maven version?): >> >> >>>>>>> >> ... >> <target name="build_maven"> >> <condition property="compiler_mvn_profiles" >> value="-Poption-with-swf" >> else="-Ddummy=true"> >> <isset property="env.AIR_HOME" /> >> </condition> >> <condition property="asjs_mvn_profiles" >> value="-Pwith-examples,with-distribution,option-with-swf" >> else="-Pwith-examples,with-distribution"> >> <isset property="env.AIR_HOME" /> >> </condition> >> <echo>Path is ${env.Path}</echo> >> >> -- >>> <exec executable="${mvn}" dir="${basedir}/${ >> maven.package.url.name}/royale-compiler" failonerror="true" >> inputstring="Yes"> >> <arg value="clean" /> >> <arg value="${compiler_mvn_profiles}" /> >> <arg value="install" /> >> </exec> >> <exec executable="${mvn}" dir="${basedir}/${ >> maven.package.url.name}/royale-typedefs" failonerror="true" > >> <arg value="clean" /> >> <arg value="install" /> >> </exec> >> <exec executable="${mvn}" dir="${basedir}/${ >> maven.package.url.name}/royale-asjs" failonerror="true" >> inputstring="Yes"> >> <arg value="clean" /> >> <arg value="${asjs_mvn_profiles}" /> >> <arg value="install" /> >> </exec> >> </target> >> ... >> <<<<<<< >> >> I have a question about licenses... Yishay has no anomalies in this >> regard but I have an unapproved license: >> Unapproved licenses: >> >> >> D:/Develop_Royale/Projects/Royale-SDK/0.9.10/apache-royale-0.9.10-bin-js-swf/royale-asjs/js/lib/royaleunit/dom4j-LICENSE.txt >> How can I fix it? >> >> [1] >> https://dist.apache.org/repos/dist/dev/royale/0.9.10/rc4/ApproveRoyale.xml >> y ejecutando el script: >> ant -e -f ApproveRoyale.xml -Drelease.version=0.9.10 -Drc=4 >> [2] >> https://drive.google.com/file/d/1jCgS51cgtRSSuh11UJUxzdEaburpDdpF/view?usp=share_link >> >> Hiedra >> >> -----Mensaje original----- >> De: Yishay Weiss <yishayj...@hotmail.com> >> Enviado el: sábado, 13 de mayo de 2023 19:36 >> Para: dev@royale.apache.org >> Asunto: [DISCUSS] Release Apache Royale 0.9.10 RC4 >> >> This is the discussion thread. >> >
