> it would be nice for users to note when their code is ready to be reviewed. You can request a specific Jira workflow from ASF Infra for your project. Typically users submit a patch or review board request and mark the jira as patch available which committers should traige for.
On Tue, Nov 17, 2015 at 4:46 PM Adina Crainiceanu <ad...@usna.edu> wrote: > All, I started a wiki page for how to contribute to Rya at > https://cwiki.apache.org/confluence/display/RYA/Contributing+to+Rya > > Josh, you are right, it would be nice for users to note when their code is > ready to be reviewed. Is there a way to add new statuses to the JIRA > tickets, so we have something like "review requested", "under review"? Or > do you suggest another way to achieve that? > > Regarding review: I think that committers should go through some review > too. Maybe if a pull request is made by a committer, then another committer > needs to review it, and then either committer can merge it? If a pull > request is made by a non-committer, maybe two committers need to review it. > We could have a minimum review period of 48 hours so everyone has a chance > to comment. What do you all think? > > Aaron, I think that the components you added are useful. Thanks for adding > them and for the JIRA tickets that you plan on taking on. I added a > "website" component and of course we need more. We can have a JIRA ticket > contribute to more than one component. > > Thanks, > Adina > > > On Tue, Nov 17, 2015 at 10:32 AM, Aaron D. Mihalik <miha...@alum.mit.edu> > wrote: > > > Josh: thanks for the advice, info, and links. > > > > Adina: I added two components that I copied from accumulo [1]: "examples" > > and "docs". Let me know if you think these are useful. Feel free to > > change/remove/merge/rename them. > > > > All: Also, I added an issue to clean up the docs structure [2] and > flush > > out an RDF Tools Example with a simple VM [3]. Please comment on these > > issues, and I'll implement them in my spare time (probably this weekend). > > I'll also use the workflow that Adina mentioned to commit these changes. > > > > > > [1] > > > > > https://issues.apache.org/jira/browse/accumulo/?selectedTab=com.atlassian.jira.jira-projects-plugin:components-panel > > [2] https://issues.apache.org/jira/browse/RYA-3 > > [3] https://issues.apache.org/jira/browse/RYA-4 > > > > On Tue, Nov 17, 2015 at 1:11 AM Josh Elser <josh.el...@gmail.com> wrote: > > > > > Agreed. > > > > > > Some things on JIRA which you might also want to setup/consider: > > > > > > * Add some components - > > > > > > > > > https://issues.apache.org/jira/plugins/servlet/project-config/RYA/components > > > * Figure out what the first release version will be - > > > > > > https://issues.apache.org/jira/plugins/servlet/project-config/RYA/versions > > > * Consider using a different workflow. It's nice to have the ability > for > > > users to note when they have some code ready for committers to review. > > > The current workflow does not have this step - > > > > > > https://issues.apache.org/jira/plugins/servlet/project-config/RYA/workflows > > > > > > If you want to go pull-request based, there may be some additional > hooks > > > you can request INFRA to set up. Making it clear how you _want_ new > > > users to contribute to the codebase is very important. This is also > > > relevant for existing committers (e.g. can committers commit their own > > > code w/o review? is there a required review period? minimum > reviewer(s)? > > > etc.) Focusing on how you expect committers and contributors to > interact > > > with the codebase is important to write down (as you let it evolve > > later). > > > > > > Seetharam Venkatesh wrote: > > > > Makes sense - please document it in the wiki. > > > > > > > > On Mon, Nov 16, 2015 at 9:27 AM Adina Crainiceanu<ad...@usna.edu> > > > wrote: > > > > > > > >> Hi all, > > > >> > > > >> We need to figure out how people can contribute to Rya, and what the > > > >> workflow should be. I looked at other projects (Accumulo, Spark) and > > the > > > >> workflow seems to be something like: > > > >> > > > >> To report a bug/propose work: > > > >> -create a JIRA ticket for the issue, using the Apache JIRA system: > > > >> https://issues.apache.org/jira/browse/RYA (new users need to > create a > > > user > > > >> account) > > > >> > > > >> To contribute code: > > > >> -find/file the JIRA ticket for that topic > > > >> -fork the code from the github Apache repo > > > >> -clone the fork, create a new branch, push commits to the branch > > > >> -create a pull request and add it to the jira ticket > > > >> -a committer will look at it and integrate it in the code /or not > > > >> > > > >> > > > >> Here are the detailed instructions from Spark: > > > >> > > > >> > > > > > > https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark#ContributingtoSpark-ContributingCodeChanges > > > >> Maybe we can create something similar. > > > >> > > > >> I think the committers should follow the same process. > > > >> > > > >> What do you think? Can someone try this workflow to see how it > works? > > > >> > > > >> Thanks, > > > >> Adina > > > >> > > > >> > > > >> > > > >> -- > > > >> Dr. Adina Crainiceanu > > > >> http://www.usna.edu/Users/cs/adina/ > > > >> > > > > > > > > > > > > > -- > Dr. Adina Crainiceanu > http://www.usna.edu/Users/cs/adina/ >
