[ https://issues.apache.org/jira/browse/S2GRAPH-23?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15091626#comment-15091626 ]
DOYUNG YOON commented on S2GRAPH-23: ------------------------------------ What others think about this? I am thinking about create following two column and deprecate hbase_table_name, hbase_table_ttl, compressionAlgorithm field. # storage_type ex) HBase(default), Redis, Postgresql, etc... # configuration_values ex) {"hbase_table_name": "s2graph-dev", "compression_algorithm": "lz4"} for hbase storage type. I am open to any other direction here so let me know what you guys think > Abstract HBase specific options from Label meta table columns > ------------------------------------------------------------- > > Key: S2GRAPH-23 > URL: https://issues.apache.org/jira/browse/S2GRAPH-23 > Project: S2Graph > Issue Type: Improvement > Reporter: DOYUNG YOON > Priority: Minor > Labels: Configuration, refactoring > Original Estimate: 168h > Remaining Estimate: 168h > > Currently Label(meta) has hbase_table_name, hbase_ttl, compression_algorithm > configuration value as column in Label table. > I think it is inevitable to store these configuration value, but current > implementation is too hbase specific. for example, redis storage might not > use hbase_table_name on label. I think it is better to store json dictionary > containing configuration values as column on Label. -- This message was sent by Atlassian JIRA (v6.3.4#6332)