[
https://issues.apache.org/jira/browse/S2GRAPH-7?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095801#comment-15095801
]
ASF GitHub Bot commented on S2GRAPH-7:
--------------------------------------
GitHub user daewon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/4
S2graph 7 abstract common code
Abstract common codes for rest project into s2core
Please refer to
[S2GRAPH-7](https://issues.apache.org/jira/browse/S2GRAPH-7?jql=project%20%3D%20S2GRAPH%20AND%20priority%20in%20(Critical%2C%20Major%2C%20Minor%2C%20Trivial)%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daewon/incubator-s2graph
s2graph-7_abstract_common_code
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/4.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4
----
commit 90777fd090e78781cb788547f1ab474899cd964e
Author: daewon <[email protected]>
Date: 2016-01-05T05:17:52Z
S2GRAPH-7 Move PostProcess.scala to s2core from root project
commit e0b3e2fe838735218ca9db7a1186552405b604c8
Author: daewon <[email protected]>
Date: 2016-01-05T06:07:20Z
S2GRAPH-7 Move RequestParser from Root to s2core
commit 64eaeeb86a79bc5fdc3a27164ca59a9d5dcda2d6
Author: daewon <[email protected]>
Date: 2016-01-05T07:23:11Z
S2GRAPH-7 Make RestCaller for abstract over http layer
commit a84c0cb27b5cf5629ccfc524083ce46441aec589
Author: daewon <[email protected]>
Date: 2016-01-05T07:59:39Z
S2GRAPH-7 Move root project to s2rest_play
commit 0ba6573a5a25291bbf4b0d285dca485e91d80775
Author: daewon <[email protected]>
Date: 2016-01-06T01:59:19Z
S2GRAPH-7 Move Test from root to s2core
commit eb5f001b0ece300e1beb6c222d1c60b4393a2a53
Author: daewon <[email protected]>
Date: 2016-01-06T08:23:52Z
S2GRAPH-7 Apply review by SteamShon
commit 7402399c39536ccbb3ccf143750ea1433a550b35
Author: daewon <[email protected]>
Date: 2016-01-07T05:57:46Z
S2GRAPH-7 remove s2ml project in build.sbt
commit 227d4957bf2042b88de70e4b27d086a9f7e29283
Author: daewon <[email protected]>
Date: 2016-01-13T08:14:34Z
Merge branch 'master' of github.com:daewon/incubator-s2graph into
s2graph-7_abstract_common_code
* 'master' of github.com:daewon/incubator-s2graph:
S2GRAPH-5: Add Apache RAT to valid LICENSE errors.
----
> Abstract common codes for rest project into s2core
> --------------------------------------------------
>
> Key: S2GRAPH-7
> URL: https://issues.apache.org/jira/browse/S2GRAPH-7
> Project: S2Graph
> Issue Type: Sub-task
> Reporter: DOYUNG YOON
> Assignee: Daewon Jeong
> Labels: project_structure, refactoring
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> s2core don`t have any way to parsing json query and building result json from
> classes.
> also finding suitable experiment and buckets under it is implemented on rest
> server. these common tasks should be moved into s2core project so multiple
> server projects can take advantage of it.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
