[
https://issues.apache.org/jira/browse/S2GRAPH-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155562#comment-15155562
]
ASF GitHub Bot commented on S2GRAPH-39:
---------------------------------------
Github user emeth-kim commented on the pull request:
https://github.com/apache/incubator-s2graph/pull/22#issuecomment-186571335
+1
> Better exception message on converting between Json and InnerVal.
> -----------------------------------------------------------------
>
> Key: S2GRAPH-39
> URL: https://issues.apache.org/jira/browse/S2GRAPH-39
> Project: S2Graph
> Issue Type: Improvement
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Trivial
> Labels: Exception
>
> Currently, converting our inner class InnerVal into JSON is done by
> {{JSONParser}}.
> I think there is lack of information why Exception has been thrown when
> converting InnerVal into Json(see innerValToJsValue method).
> It would be better provide more informations as following.
> 1. what was the innerVal value we are trying to convert.
> 2. what was actual dataType of innerVal we are trying to convert.
> 3. what dataType this innerVal need to be converted into in Json.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
