[ 
https://issues.apache.org/jira/browse/S2GRAPH-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155563#comment-15155563
 ] 

ASF GitHub Bot commented on S2GRAPH-40:
---------------------------------------

Github user emeth-kim commented on the pull request:

    https://github.com/apache/incubator-s2graph/pull/23#issuecomment-186571343
  
    +1


> PostProcess.toHashKey gives different hash key with same value when edge's 
> label schema version is different.
> -------------------------------------------------------------------------------------------------------------
>
>                 Key: S2GRAPH-40
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-40
>             Project: S2Graph
>          Issue Type: Bug
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>              Labels: bug, testcase
>
> since hashCode of InnerVal on v1, v2 is different, same innerVal with string 
> value "a" gives different hash key if schema version is different.
> This cause problem when filterOut is given or exclude is specified on 
> queryParam since they compare hash key on to field of Edge and this hash key 
> is produced by innerVal.hashCode. 
> I think we can bypass this problem by using .toString on innerVal at 
> toHashKey. 
> Also there is no test cases for this so it is necessary to add it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to