[
https://issues.apache.org/jira/browse/S2GRAPH-41?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155564#comment-15155564
]
ASF GitHub Bot commented on S2GRAPH-41:
---------------------------------------
Github user emeth-kim commented on the pull request:
https://github.com/apache/incubator-s2graph/pull/24#issuecomment-186571345
+1
> Refactor PostProcess's toSimpleVertexArrJson.
> ---------------------------------------------
>
> Key: S2GRAPH-41
> URL: https://issues.apache.org/jira/browse/S2GRAPH-41
> Project: S2Graph
> Issue Type: Improvement
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Trivial
> Labels: easyfix, refactor
>
> There is two large logic is coupled in PostProcess.toSimpleVertexArrJson.
> 1. build edges from Seq[QueryRequestWithResult] with their score value.
> 2. group by and order by is processed after 1 is done.
> It would be better to seperate these two logical step into two methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
