[ 
https://issues.apache.org/jira/browse/S2GRAPH-43?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155637#comment-15155637
 ] 

ASF GitHub Bot commented on S2GRAPH-43:
---------------------------------------

Github user daewon commented on the pull request:

    https://github.com/apache/incubator-s2graph/pull/26#issuecomment-186611119
  
    +1


> Bug on offset when Interval is given on query.
> ----------------------------------------------
>
>                 Key: S2GRAPH-43
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-43
>             Project: S2Graph
>          Issue Type: Bug
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>            Priority: Trivial
>              Labels: easyfix
>
> Since {{degreeEdge}} that store how many edges are exist from this source 
> vertex use empty byte array as qualifier, it always comes at first. 
> Above is reason why we add 1 on limit when offset is 0(if offset is 0, then 
> we need to return degree too so storage level limit should be increased by 1).
> This is not actually true when "interval" is given.
> When query has interval option, then it use columnRangeFilter, and with 
> offset 0 and interval option, then current implementation return 1 more 
> result. 
> I think adding 1 on provided limit should check if interval is specified on 
> queryParam.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to