[
https://issues.apache.org/jira/browse/S2GRAPH-45?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158990#comment-15158990
]
ASF GitHub Bot commented on S2GRAPH-45:
---------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/31
[S2GRAPH-45] Provide way to call specific bucket on experiment.
pass impressionId from header into s2core so user can specify specific
becket under experiment.
previous PR #29 missed out s2rest_netty subproject's Server.scala. so I am
re-requesting PR for S2GRAPH-45 again.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-45
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/31.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #31
----
commit 697c7962ca751a427eae66d1a034b6f0c4ca26e2
Author: DO YUNG YOON <steams...@apache.org>
Date: 2016-02-23T10:30:59Z
pass impressionIdOption into experiment api.
commit 424ce9bf09f0133339570d2ba045502a8412de7c
Author: DO YUNG YOON <steams...@apache.org>
Date: 2016-02-23T10:43:11Z
apply specific bucket finding.
commit 35dc0690e50aefe9cccf0272ac857cdf647f638a
Author: DO YUNG YOON <steams...@apache.org>
Date: 2016-02-23T14:45:34Z
fix compile error.
commit b6d56d7f2b8c668e07362507317ce4badd80a0b5
Author: DO YUNG YOON <steams...@apache.org>
Date: 2016-02-23T14:49:46Z
Merge branch 'master' into S2GRAPH-45
----
> Provide way to call specific bucket on experiment.
> --------------------------------------------------
>
> Key: S2GRAPH-45
> URL: https://issues.apache.org/jira/browse/S2GRAPH-45
> Project: S2Graph
> Issue Type: New Feature
> Reporter: DOYUNG YOON
> Assignee: Daewon Jeong
> Priority: Minor
> Labels: server
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> Current implementation call Random number to pick specific bucket under
> experiment.
> It would be much better if we can call specific bucket even though there is
> not traffic ratio is assigned into bucket, for debug and make sure bucket's
> query is working.
> I am suggesting accepting impressionId on specific bucket as header on http
> post request.
> if use provide specific impressionId on experiment request, we call that
> bucket and if user don't provide it, then run random and decide which bucket
> should be called.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
