[ https://issues.apache.org/jira/browse/S2GRAPH-17?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15171348#comment-15171348 ]
ASF GitHub Bot commented on S2GRAPH-17: --------------------------------------- GitHub user SteamShon opened a pull request: https://github.com/apache/incubator-s2graph/pull/33 [S2GRAPH-17] Remove unnecessary abstraction layer, Storage. This is quite large PR. apologize for large changes. The main motivation on this PR is changing followings. 1. remove unnecessary abstraction like MutationBuilder, QueryBuilder. 2. make code more understandable for otheres, especially for who is interested in implementing other storage backend. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-17 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-s2graph/pull/33.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #33 ---- commit 4d4f06dac338c904177ec2b35115b518b469638c Author: SteamShon <sho...@gmail.com> Date: 2015-12-06T05:24:54Z restructure project. root project becomes s2rest_play commit da855866d2aa3b6bb57e0cf16b3f6451a362ae9f Author: SteamShon <sho...@gmail.com> Date: 2015-12-06T05:51:07Z fix compile error by downgrade version of ascii-graphs on s2ml. commit 97c926e412a59324f5daa0d3423023b2c70a86cc Author: Jaesang Kim <honeysl...@gmail.com> Date: 2015-12-06T16:12:30Z Squashed commit of the following: commit 547820cb7ee4791c1da48e7028c63529d2d79aa4 Author: Jaesang Kim <honeysl...@gmail.com> Date: Sun Dec 6 23:27:51 2015 +0900 delete unused file commit aabdcfdb390e73bb8f19d95037cbba3dad2ff932 Author: Jaesang Kim <honeysl...@gmail.com> Date: Sun Dec 6 01:24:06 2015 +0900 update README commit 7913f62ad6f4f0031e2ae4d1ebaf22c25577d80e Merge: 5eb4838 1bb3b6d Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Dec 4 23:53:09 2015 +0900 Merge remote-tracking branch 'origin/develop' into feature/dev_support commit 5eb48388f6a8a89b081fcf10949544747cdeb931 Author: Jaesang Kim <honeysl...@gmail.com> Date: Thu Nov 19 14:47:19 2015 +0900 change graph version commit e17cf178466000e963cb1398c26aab3812e59e19 Author: Jaesang Kim <honeysl...@gmail.com> Date: Thu Nov 19 00:31:07 2015 +0900 update README.md commit b536a1c37dcc692ef374800fc6e281b4414a2525 Author: Jaesang Kim <honeysl...@gmail.com> Date: Thu Nov 19 00:30:33 2015 +0900 update README.md commit b1e6d45ec432e00c34ca29f70fb1c7b38c2716f1 Author: Jaesang Kim <honeysl...@gmail.com> Date: Thu Nov 19 00:12:49 2015 +0900 update README.md commit f1e0a7fd2707d0d0e32c08bafb5b276d6fdcd53c Author: Jaesang Kim <honeysl...@gmail.com> Date: Thu Nov 19 00:12:06 2015 +0900 update README.md commit 0f541dd56233089ba95b62dd11e1c47054c9ccd6 Author: Jaesang Kim <honeysl...@gmail.com> Date: Wed Nov 18 23:56:00 2015 +0900 update README.md commit 52f75c5e671cb8d915463b6023722141a49a17c0 Merge: e3f6970 9da14f3 Author: Jaesang Kim <honeysl...@gmail.com> Date: Wed Nov 18 22:39:58 2015 +0900 Merge branch 'feature/dev_support' of github.com:kakao/s2graph into feature/dev_support commit e3f6970c16d67913b4b965df6e34c02dc8d7e716 Merge: 763635c 8366ebc Author: Jaesang Kim <honeysl...@gmail.com> Date: Wed Nov 18 22:37:03 2015 +0900 Merge branch 'develop' into feature/dev_support commit 9da14f3652632cdfd11830ac26858b02d5489919 Author: Jaesang Kim <honeysl...@gmail.com> Date: Wed Nov 18 11:26:11 2015 +0900 update README.md commit b93dca50fca2c17b5cb927d019812e16b0cac912 Merge: 763635c d2bd5fc Author: Jaesang Kim <honeysl...@gmail.com> Date: Wed Nov 18 11:15:22 2015 +0900 Merge remote-tracking branch 'origin/develop' into feature/dev_support commit 763635c67525bebc1d30dbcef03d45e3ef7b74c9 Merge: dc8e0cc 3c1be8e Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Nov 13 18:58:24 2015 +0900 Merge remote-tracking branch 'origin/develop' into feature/dev_support commit dc8e0cc6464dea2a8f725599bc5003f0ade992e2 Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Nov 13 18:11:09 2015 +0900 add docker-compose commit 8f7f9e5d447e0e1b52c23523d8ff57a23bd62b91 Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Nov 13 13:42:21 2015 +0900 change run script commit 7d502088d087a38a2c1483414aa8069cfdb48383 Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Nov 13 11:46:20 2015 +0900 change schema.sql commit 8aed82a68e9a5b01fd0fb98cce7a0441e146edc5 Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Nov 13 11:04:23 2015 +0900 add conf/application.conf commit 09c32c4f7229086db4b5cf77e4e8bcd7c743d6d2 Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Nov 13 10:47:45 2015 +0900 add dockerExposedPorts commit 073381caa7516cbeb3619b41447ba6e1ea2e58e0 Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Nov 13 10:43:31 2015 +0900 docker for s2graph commit 5c663922baa7fb8126da2ea277e9af81fe2de44f Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Nov 13 02:35:21 2015 +0900 support docker commit 3c6a4de62e76bb4af714823f2891e1d023f93deb Merge: bb04c0a 32ca022 Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Nov 13 01:58:18 2015 +0900 Merge remote-tracking branch 'origin/develop' into feature/dev_support commit bb04c0adf601dd4f612016509103acdf4c13b903 Merge: 9210ca4 f0e52a6 Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Oct 30 19:24:26 2015 +0900 Merge remote-tracking branch 'origin/develop' into feature/dev_support commit 9210ca45dfb1f46eec4b27cdfc201bc85604f65f Merge: c26645e 2786b18 Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Oct 30 16:50:37 2015 +0900 Merge branch 'feature/issue#155' into feature/dev_support commit c26645edb003f5cede516abb29007dc475d2af4e Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Oct 30 16:50:31 2015 +0900 add schema.sql commit fdba07bb132128ab0937e4b1823ff9d1cbc53861 Merge: fbabc34 c7a8aff Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Oct 30 15:42:46 2015 +0900 Merge branch 'feature/issue#155' into develop commit fbabc34594b90505fad172902e2ab29a80b7543d Author: Jaesang Kim <honeysl...@gmail.com> Date: Fri Oct 30 15:34:46 2015 +0900 script for dev-support using docker commit 3f50c7ec72106b429a16fea27fc9da2a0f29f953 Author: daewon <blue...@gmail.com> Date: 2015-12-07T02:52:38Z Sep dependency commit 53a22ce3fc02604a4ed3f88fa8c7eaf2574b374b Author: daewon <blue...@gmail.com> Date: 2015-12-07T03:20:38Z Merge pull request #198 from kakao/feature/Issue#195 Feature/issue#195 :+1: commit d779bc78ef02ba5d3e57158d9490cc2b121e1f19 Author: daewon <blue...@gmail.com> Date: 2015-12-07T05:14:55Z Add Finagle Rest server commit 55a2121d244a335a363edb6abff97bc69444a098 Author: daewon <blue...@gmail.com> Date: 2015-12-07T06:27:12Z Add logger commit 5c896135bb21f459acc16a8861b13aa6fc3d8e9e Author: daewon <blue...@gmail.com> Date: 2015-12-07T06:54:04Z add logger commit 6c3470aa53b4831cc76cf53e51a98d79f97fd5b1 Author: daewon <blue...@gmail.com> Date: 2015-12-07T07:04:53Z Add native packager commit b7b25344275e3a13a1e9ae770deedf73f3628832 Author: daewon <blue...@gmail.com> Date: 2015-12-07T07:32:41Z add Shutdown hook commit 89f0fa0fe6785c32eaf15f80f9f1f496fcb2b9a5 Author: daewon <blue...@gmail.com> Date: 2015-12-07T10:04:25Z Add backlog commit dbe7b3249cc0ac128c6ca2b75638c53b11f8e50d Author: daewon <blue...@gmail.com> Date: 2015-12-07T10:08:28Z change thread pool commit ea902966af2b7829c9a793b47173c56a5ef59323 Author: daewon <blue...@gmail.com> Date: 2015-12-07T10:09:46Z set keep-alive commit ba3be31957b21fd1ed29fbed403be29fb2c105bf Author: daewon <blue...@gmail.com> Date: 2015-12-07T10:16:33Z remove await commit 350f8674c5c9b999fecec8b72a65842d57182af9 Author: daewon <blue...@gmail.com> Date: 2015-12-07T10:35:09Z reduce max concurrent commit 483d9b5df59312a3d4c134c6263872c43e33edcb Author: daewon <blue...@gmail.com> Date: 2015-12-07T10:44:12Z remove logger commit 5f39c5b68a453fd9a0a9d9020dd69a7f9bf2b2f4 Author: daewon <blue...@gmail.com> Date: 2015-12-07T15:20:37Z add netty server commit 5f209bdf06fe11aac1fd74ba5d3a83048d38f8f2 Author: daewon <blue...@gmail.com> Date: 2015-12-07T16:26:51Z add res sizet commit d3f24e9942a6e02ccdb738a0fb8bf1866d06d487 Author: SteamShon <sho...@gmail.com> Date: 2015-12-07T22:13:22Z migrate most of routes on QueryController. logging + json result size + header need to be correctly implemented before deploy. commit 097b56236f2f342a41a450a31612035864c025c5 Author: SteamShon <sho...@gmail.com> Date: 2015-12-08T01:09:51Z netty version up commit 6ff42469183bc2e367964fcde5a833592b3c0e82 Author: SteamShon <sho...@gmail.com> Date: 2015-12-08T01:31:05Z change name for s2rest_netty commit c2faef748eef1d4d1b199833b3401196d4a9724d Author: SteamShon <sho...@gmail.com> Date: 2015-12-08T01:46:01Z bug fix on keepAlive. commit 098a9f212a6a7d5b7143bfd7f0e7ea508f4ffee9 Author: SteamShon <sho...@gmail.com> Date: 2015-12-08T02:03:38Z add duration on logging. commit f91c49b48e5c40e9ff80e5834ae42f7fe4441eba Author: Jaesang Kim <honeysl...@gmail.com> Date: 2015-12-08T03:17:11Z Merge remote-tracking branch 'origin/develop' into feature/Issue#196 commit c475249406dd3f6f800a59fbf831833fb37d798e Author: SteamShon <sho...@gmail.com> Date: 2015-12-08T04:53:16Z add logger on size. commit 3029d0b05987d1ee260ee32ddf45c54057365318 Author: daewon <blue...@gmail.com> Date: 2015-12-08T05:28:02Z Write response on error commit 527a567521ddd8b68b3bfabb3bf0e3be47613112 Author: SteamShon <sho...@gmail.com> Date: 2015-12-08T06:09:12Z Merge branch 'feature/bug_fix_lock_edge' into develop commit 291cdcb4f7f3d16067253ef1487714eecba87461 Author: daewon <blue...@gmail.com> Date: 2015-12-08T09:53:26Z Revive TC commit f539631adc3b6aaf5d12a52362285dc316772d8a Author: daewon <blue...@gmail.com> Date: 2015-12-08T15:59:59Z Merge pull request #200 from kakao/feature/netty_poc Feature/netty poc :+1: commit 8d3b6111119e63623be4764331d9d465199e0550 Author: daewon <blue...@gmail.com> Date: 2015-12-09T02:11:20Z Remove unnecessary files ---- > Remove unnecessary abstraction layer, Storage. > ---------------------------------------------- > > Key: S2GRAPH-17 > URL: https://issues.apache.org/jira/browse/S2GRAPH-17 > Project: S2Graph > Issue Type: Task > Reporter: DOYUNG YOON > Assignee: DOYUNG YOON > Labels: client, refactoring > Original Estimate: 168h > Remaining Estimate: 168h > > Currently Graph contains following components. > Graph has storage and each storage have followings. > # SerDe: serialize and deserialize IndexEdge/SnapshotEdge/Vertex into bytes. > # MutationBuilder: convert IndexEdge/SnapshotEdge into RPC which is dependent > on storage backend. > # QueryBuilder: issue RPC for fetch on storage backend > With these components, storage know how to actually store/fetch > IndexEdge/SnapshotEdge/Vertex to, from storage backend. > In my opinion, storage layer is unnecessary since all graph instance does is > delegating into storage. I am suggesting to remove storage layer and use > different Graph class for different storage backend. > So for example, change AsynchbaseStorage into AsynchbaseGraph. > I want to discuss how our Graph Client should be on this issue and change it > according to discussion. -- This message was sent by Atlassian JIRA (v6.3.4#6332)