[
https://issues.apache.org/jira/browse/S2GRAPH-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15646502#comment-15646502
]
ASF GitHub Bot commented on S2GRAPH-124:
----------------------------------------
GitHub user SteamShon opened a pull request:
https://github.com/apache/incubator-s2graph/pull/92
[S2GRAPH-124]: Change JSONParser from Trait to Object.
+ change JSONParser trait to object.
+ add more helper methods.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-124
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-s2graph/pull/92.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #92
----
commit 38df9f8c213ec847da08d09ef9ef4bdf809fb939
Author: DO YUNG YOON <steams...@apache.org>
Date: 2016-11-08T04:52:41Z
[S2GRAPH-124]: Change JSONParser from Trait to Object.
----
> Change JSONParser from Trait to Object.
> ---------------------------------------
>
> Key: S2GRAPH-124
> URL: https://issues.apache.org/jira/browse/S2GRAPH-124
> Project: S2Graph
> Issue Type: Improvement
> Affects Versions: 0.2.0
> Reporter: DOYUNG YOON
> Assignee: DOYUNG YOON
> Priority: Minor
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> I think JSONParser should be changed from Trait to Object since there are
> many classes extends this Trait. It would be better locate all format
> converting logic from inner class to Json and vice verse in this object and
> simply import object’s method when it is needed.
> Currently there are many classes that extending JSONParser and I think this
> is unncessary.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
