[ https://issues.apache.org/jira/browse/S2GRAPH-187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16413252#comment-16413252 ]
ASF GitHub Bot commented on S2GRAPH-187: ---------------------------------------- GitHub user SteamShon opened a pull request: https://github.com/apache/incubator-s2graph/pull/142 [S2GRAPH-187]: Make toQuery use toVertex to parse vertex from query JSON on RequestParser - refactor `toVertex` to be shared on `toQuery`. - add a test case on VertexTestHelper(escaping of double quotation marks). You can merge this pull request into a Git repository by running: $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-187 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-s2graph/pull/142.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #142 ---- commit f40affb7a3abfc7d7ec9b60831e6112075d96939 Author: DO YUNG YOON <steamshon@...> Date: 2018-03-22T12:22:12Z make toQuery to use toVertex. commit 87a8cedd00291f2bce9b14ea11df6e9a50d02fa0 Author: DO YUNG YOON <steamshon@...> Date: 2018-03-26T00:57:25Z add test cases to test S2GRAPH-186. ---- > Make toQuery use toVertex to parse vertex from query JSON on RequestParser > -------------------------------------------------------------------------- > > Key: S2GRAPH-187 > URL: https://issues.apache.org/jira/browse/S2GRAPH-187 > Project: S2Graph > Issue Type: Improvement > Reporter: DOYUNG YOON > Assignee: DOYUNG YOON > Priority: Trivial > Original Estimate: 48h > Remaining Estimate: 48h > > There is code duplication on `toQuery` and `toVertex` at `RequestParser`. > Both of two methods need to read JSON value and extract vertex. > The only difference between two is `toQuery` only need vertexId, not props, > timestamp, operation, but `toVertex` need others. > Different implementation increase probability for bugs like S2GRAPH-186, so I > suggest refactoring theses. -- This message was sent by Atlassian JIRA (v7.6.3#76005)