Hi, Hope you don’t mind the intrustion but I thought I’d take a look at your RC. As I only have a limited knowledge of your project I may of got a few things wrong.
There's a couple of things I would consider blockers if it was put to a vote on the IPMC list. There is a jar in the source release: ./samoa-0.3.0-incubating/bin/s4-build/gradle-wrapper-1.4.jar Having a jar in a source release is not possible. [1] This exact issue has come up on the incubator before you might want to search for it and see how it was resolved by other projects. From what I can see MOA is under GPL which is a category X license not an Apache compatable license [3] You may want to double check this. It may be that this is an optional dependancy and this has been discussed and that may be OK. I’m reasonably sure it can’t be re-licensed under Apache. However I don’t know enough about your project to know the exact particulars or the code in question. The source release is missing a DISCLAIMER file [4] Other minor issues: 2 files are missing apache headers: ./samoa-0.3.0-incubating/samoa-test/src/test/java/org/apache/samoa/TestParams.java ./samoa-0.3.0-incubating/samoa-threads/src/main/java/org/apache/samoa/LocalThreadsDoTask.java You may want to change the NOTICE so it says “Apache Samoa (incubating)” rather than "Apache SAMOA". The disclaimer in the NOTICE file is a little unusual (See [5] for a simple NOTICE file) as only things that are actually bundled in the distribution need to be mentioned in LICENSE or NOTICE. [2] Or files that have copyright headers changed but again I’m reasonable sure you can’t change GPL code to be Apache licensed as you’re removed the copyleft provision that the GPL license granted. This line: public static final String copyrightNotice = "Copyright Yahoo! Inc 2013”; In: ./samoa-api/src/main/java/org/apache/samoa/core/Globals.java Is probably not correct. Although you may want to list Yahoo in the NOTICE file as the original developers of the software (again see [5] for example). Thanks, Justin 1. http://incubator.apache.org/guides/releasemanagement.html#check-list (see 3.6) 2. http://www.apache.org/dev/licensing-howto.html#guiding-principle 3. http://www.apache.org/legal/resolved.html#category-x 4. http://incubator.apache.org/guides/releasemanagement.html#check-list (see 3.1) 5. http://www.apache.org/dev/licensing-howto.html#simple
