Github user gdfm commented on the pull request:
https://github.com/apache/incubator-samoa/pull/40#issuecomment-154997618
Overall looks pretty good!
Tested on Local and Storm 0.9.6.
If you can address a couple of minor comments, I am +1.
@abifet @nicolas-kourtellis could you have a look at it as well, we need
another +1.
I'd also like to include the format docs somewhere. Probably the Wiki is
the easiest place, but I'm open to better ideas.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
