Hi Justin, Thanks for taking the time to review the release candidate.
I am working on updating the licencing in the files now. It seems to me that the previous 2 releases under Apache incubation used the licences as they stand - has Apache's licencing guidelines changed recently? Or was this an oversight? I have contacted Łukasz Ławniczak and received his permission to remove the copyright from the files where he is named. Does Apache recommend a standard way for automating the licence checking process? SAMOA currently uses the licence-maven-plugin but I am thinking of moving to maven-checkstyle-plugin as it is more flexible in checking the licence and can also support code-style checks. But if Apache already has some configuration for this, that would be preferable. Thanks, Corey. On Tue, Dec 3, 2019 at 10:02 AM Justin Mclean <[email protected]> wrote: > Hi, > > I took a quick look at the release and I would probably be -1 on it if > this come up for an IPMC vote as you are not using the standard ASF header > on your source files. The standard header for ASF projects doesn't include > a copyright line. I also see some files copyright Łukasz Ławniczak, who is > not mentioned in LICENSE and that NOTICE is incorrect that it mentions > bundled software that should be listed in LICENSE. > > Thanks, > Justin >
