----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33761/#review82361 -----------------------------------------------------------
We would need a unit test to ensure the fix is effective. I.e. create a cached store, creating an iterator, call iterator.remove() and verify that the entry is deleted from the cache. samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala <https://reviews.apache.org/r/33761/#comment133093> This iterator needs to be wrapped as well. samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala <https://reviews.apache.org/r/33761/#comment133094> nit: If we are cleaning up the coding style, should be consistent w/ wrapperStore.flush() here as well. samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala <https://reviews.apache.org/r/33761/#comment133095> nit: same here. - Yi Pan (Data Infrastructure) On May 1, 2015, 6:43 p.m., Guozhang Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/33761/ > ----------------------------------------------------------- > > (Updated May 1, 2015, 6:43 p.m.) > > > Review request for samza. > > > Bugs: SAMZA-658 > https://issues.apache.org/jira/browse/SAMZA-658 > > > Repository: samza > > > Description > ------- > > Add removing logic to the intermediate cached store for kv engine > > > Diffs > ----- > > > samza-kv/src/main/scala/org/apache/samza/storage/kv/BaseKeyValueStorageEngineFactory.scala > b3624e6057ee1a86090f00d2853035b06f63358d > samza-kv/src/main/scala/org/apache/samza/storage/kv/CachedStore.scala > 61bb3f6acb080b653f8b11176538549738255acc > > samza-kv/src/main/scala/org/apache/samza/storage/kv/KeyValueStorageEngine.scala > 3a23daf053f0b8dec3a7ec83a51c9c5527078a3b > > Diff: https://reviews.apache.org/r/33761/diff/ > > > Testing > ------- > > > Thanks, > > Guozhang Wang > >
