-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33735/#review83688
-----------------------------------------------------------



samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
<https://reviews.apache.org/r/33735/#comment134726>

    floor vs. round -- thoughts?


- Mohamed Mahmoud (El-Geish)


On May 13, 2015, 11:10 p.m., Naveen Somasundaram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33735/
> -----------------------------------------------------------
> 
> (Updated May 13, 2015, 11:10 p.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> RocksDB TTL support
> https://issues.apache.org/jira/browse/SAMZA-537
> https://issues.apache.org/jira/browse/SAMZA-442
> 
> Please ignore the maven link added to build.gradle, I'll remove it once I 
> validate the release is good.
> 
> 
> Diffs
> -----
> 
>   build.gradle ac80a8664180e556ec83e229e04e3d8c56b70506 
>   docs/learn/documentation/versioned/jobs/configuration-table.html 
> 728197d01d1e3f551ea53e2a14e97df44e29ee19 
>   gradle/dependency-versions.gradle ee6dfc411b7ab90b187df79f109884127953862e 
>   
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStorageEngineFactory.scala
>  5ab68590a4ed2686d730344665e25776cade6add 
>   
> samza-kv-rocksdb/src/main/scala/org/apache/samza/storage/kv/RocksDbKeyValueStore.scala
>  dd20f171491da4b4d900551932b2a06d58526d73 
>   
> samza-kv-rocksdb/src/test/scala/org/apache/samza/storage/kv/TestRocksDbKeyValueStore.scala
>  PRE-CREATION 
>   
> samza-test/src/test/scala/org/apache/samza/storage/kv/TestKeyValueStores.scala
>  9dee7be9a58c491dbd1a6b9cf73d5c111c570da2 
> 
> Diff: https://reviews.apache.org/r/33735/diff/
> 
> 
> Testing
> -------
> 
> Added Unit test
> 
> 
> Thanks,
> 
> Naveen Somasundaram
> 
>

Reply via email to