-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34207/
-----------------------------------------------------------
Review request for samza, Yan Fang, Chris Riccomini, Guozhang Wang, Milinda
Pathirage, Navina Ramesh, and Naveen Somasundaram.
Bugs: SAMZA-552
https://issues.apache.org/jira/browse/SAMZA-552
Repository: samza
Description
-------
SAMZA-552: use OperatorCallback to allow implementation of callbacks w/o
inheriting and creating many sub-classes from operators
- This is a further iteration of the Operator API that includes the
OperatorCallback interface
The benefit of having a separate OperatorCallback interface is that the user
can implement a common callback class once and be used by any different
instantiation of operator classes. Uses does not need to extend each operator
class to overide the beforeProcess() and beforeSend() methods.
Diffs
-----
samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/OperatorCallback.java
PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/api/operators/SimpleOperator.java
PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/NoopOperatorCallback.java
PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/factory/SimpleOperatorImpl.java
PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/join/StreamStreamJoin.java
PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/partition/PartitionOp.java
PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/sql/operators/window/BoundedTimeWindow.java
PRE-CREATION
samza-sql-core/src/main/java/org/apache/samza/task/sql/SimpleMessageCollector.java
PRE-CREATION
samza-sql-core/src/test/java/org/apache/samza/sql/operators/window/MyBoundedTimeWindow.java
PRE-CREATION
samza-sql-core/src/test/java/org/apache/samza/task/sql/RandomWindowOperatorTask.java
PRE-CREATION
samza-sql-core/src/test/java/org/apache/samza/task/sql/StreamSqlTask.java
PRE-CREATION
samza-sql-core/src/test/java/org/apache/samza/task/sql/UserCallbacksSqlTask.java
PRE-CREATION
Diff: https://reviews.apache.org/r/34207/diff/
Testing
-------
Thanks,
Yi Pan (Data Infrastructure)
