----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35067/#review87963 -----------------------------------------------------------
@Robert: Can you please add a unit test in TestKafkaConfig to verify that these properties get overridden correctly ? Sorry about this afterthought request. - Navina Ramesh On June 15, 2015, 1:42 p.m., Robert Zuljevic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35067/ > ----------------------------------------------------------- > > (Updated June 15, 2015, 1:42 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Fixed test > > > Diffs > ----- > > samza-kafka/src/main/scala/org/apache/samza/config/KafkaConfig.scala > a1de88781a8ff2a3fe50389ae7a59062289404fc > > samza-test/src/test/scala/org/apache/samza/test/integration/TestStatefulTask.scala > 82006960adc45a92a79e28f078ebd5eb01d3205e > > Diff: https://reviews.apache.org/r/35067/diff/ > > > Testing > ------- > > > Thanks, > > Robert Zuljevic > >
