> On July 13, 2015, 9:44 p.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala, > > line 636 > > <https://reviews.apache.org/r/36089/diff/1/?file=996581#file996581line636> > > > > I think a better way, which requires much fewer changes, is to call > > something like jmxServer.getJmxUrl, jmxServer.jmxTunelingUrl. > > > > jmxServer can be a variable of SamzaContainer Object. > > > > Then we do not need to change ContainerModel, JobModel, SamzaContext. > > Because there is no reason that we want to contain jmx information into > > those three objects.
The new patch fixes this issue. Also, whn I created the new patch, I merged the master branch back to my local SAMZA-670 branch, so the new diff can be cleanly applied to master. - József Márton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36089/#review91533 ----------------------------------------------------------- On July 14, 2015, 1:30 p.m., József Márton Jung wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36089/ > ----------------------------------------------------------- > > (Updated July 14, 2015, 1:30 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > JMX address of application master and the containers is available through AM > UI > > > Diffs > ----- > > checkstyle/import-control.xml 3374f0c > samza-core/src/main/java/org/apache/samza/container/LocalityManager.java > e661e12 > > samza-core/src/main/java/org/apache/samza/coordinator/stream/CoordinatorStreamMessage.java > 6c1e488 > samza-core/src/main/java/org/apache/samza/job/model/JobModel.java 95a2ce5 > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > cbacd18 > samza-core/src/main/scala/org/apache/samza/coordinator/JobCoordinator.scala > 8ee034a > samza-core/src/main/scala/org/apache/samza/job/local/ThreadJobFactory.scala > 3f2f70e > samza-core/src/main/scala/org/apache/samza/metrics/JmxServer.scala f343faf > > samza-core/src/test/scala/org/apache/samza/container/TestSamzaContainer.scala > 9fb1aa9 > samza-yarn/src/main/resources/scalate/WEB-INF/views/index.scaml cf0d2fc > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMaster.scala > 20aa373 > > samza-yarn/src/main/scala/org/apache/samza/job/yarn/SamzaAppMasterState.scala > 1445605 > > Diff: https://reviews.apache.org/r/36089/diff/ > > > Testing > ------- > > > Thanks, > > József Márton Jung > >
