> On July 21, 2015, 5:42 p.m., Yan Fang wrote: > > samza-core/src/main/scala/org/apache/samza/metrics/MetricsHelper.scala, > > lines 36-37 > > <https://reviews.apache.org/r/36473/diff/3/?file=1017436#file1017436line36> > > > > though it works, prefer to use the "def" here, not only because it has > > leff overhead, but also keep all the methods consistent for better > > readability. What do you think? > > Roger Hoover wrote: > Sounds good. I only baulked on it the first time because I'm not that > skilled with Scala type decarations yet. :) I can make this work > > Roger Hoover wrote: > I take it back. It seems it [can't be > done](http://www.scala-lang.org/old/node/5082)
aha, sorry for the misleading. I think, what I mean here is to change the "val" to "def": val newCounter = metricGroup.newCounter(_) ==> def newCounter(name: String). - Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36473/#review92429 ----------------------------------------------------------- On July 22, 2015, 4:07 a.m., Roger Hoover wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/36473/ > ----------------------------------------------------------- > > (Updated July 22, 2015, 4:07 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > SAMZA-733 Add metrics to Elasticsearch System Producer > > > Diffs > ----- > > samza-core/src/main/java/org/apache/samza/metrics/MetricGroup.java > PRE-CREATION > samza-core/src/main/java/org/apache/samza/metrics/MetricsBase.java > PRE-CREATION > samza-core/src/main/scala/org/apache/samza/metrics/MetricsHelper.scala > 8eac8ef > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemFactory.java > a277b69 > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java > 7eb14a2 > > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetrics.java > PRE-CREATION > > samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetricsTest.java > PRE-CREATION > > samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerTest.java > e63d62c > > Diff: https://reviews.apache.org/r/36473/diff/ > > > Testing > ------- > > Tested that metrics for Elasticsearch producer appear in JMX and the metrics > stream and that the metrics correctly count how many Elasticsearch documents > were created and indexed. > > > Thanks, > > Roger Hoover > >
