> On July 29, 2015, 8:42 a.m., Dan Harvey wrote:
> > samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java,
> > line 116
> > <https://reviews.apache.org/r/36815/diff/6/?file=1024157#file1024157line116>
> >
> > Should we add a Samza specifc message, then add the whole exception? so
> > it's more clear what the exception was from if the user doesn't know the
> > code? `Logger.info("Failed to index message in ElasticSearch.", e);`
> >
> > This would also be true for other log lines added.
Good idea. Thanks.
BTW, it didn't work like this: Logger.info("Failed to index message in
ElasticSearch.", itemResp.getFailure()) so I did this:
LOGGER.error("Failed to index document in Elasticsearch: " +
itemResp.getFailureMessage());
- Roger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36815/#review93413
-----------------------------------------------------------
On July 29, 2015, 6:22 a.m., Roger Hoover wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36815/
> -----------------------------------------------------------
>
> (Updated July 29, 2015, 6:22 a.m.)
>
>
> Review request for samza and Dan Harvey.
>
>
> Repository: samza
>
>
> Description
> -------
>
> SAMZA-741 Add support for versioning to Elasticsearch System Producer
>
>
> Diffs
> -----
>
>
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducer.java
> f61bd36
>
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetrics.java
> e3b635b
>
> samza-elasticsearch/src/main/java/org/apache/samza/system/elasticsearch/indexrequest/DefaultIndexRequestFactory.java
> afe0eee
>
> samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerMetricsTest.java
> 980964f
>
> samza-elasticsearch/src/test/java/org/apache/samza/system/elasticsearch/ElasticsearchSystemProducerTest.java
> 684d7f6
>
> Diff: https://reviews.apache.org/r/36815/diff/
>
>
> Testing
> -------
>
> Refactored DefaultIndexRequestFactory to make it easier to subclass and
> customize to handle version and version_type parameters.
>
>
> Thanks,
>
> Roger Hoover
>
>
