----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37536/#review95672 -----------------------------------------------------------
I believe this patch works, but could you also add a unit test to verify the correctness? Also overusing the localityManager is a little concerned, could you think of another way? Thank you. samza-core/src/main/java/org/apache/samza/job/model/JobModel.java (line 74) <https://reviews.apache.org/r/37536/#comment150767> this is a little overuse of the localityManager. It is not designed to get the latest config. samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala (line 106) <https://reviews.apache.org/r/37536/#comment150765> sanitize it as well. - Yan Fang On Aug. 17, 2015, 2:56 p.m., Aleksandar Bircakovic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37536/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2015, 2:56 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > WebServlet and RestServlet now read information from coordinator stream > consumer and get new config. > > > Diffs > ----- > > > samza-core/src/main/java/org/apache/samza/coordinator/stream/AbstractCoordinatorStreamManager.java > ca97ce8 > samza-core/src/main/java/org/apache/samza/job/model/JobModel.java 7b59274 > > samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala > 09f4dc3 > > samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterWebServlet.scala > 7fd5122 > > Diff: https://reviews.apache.org/r/37536/diff/ > > > Testing > ------- > > > Thanks, > > Aleksandar Bircakovic > >
