----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37604/#review96145 -----------------------------------------------------------
Overall, LGTM. Could you also add a unit test to verify this? Thank you. samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala (line 581) <https://reviews.apache.org/r/37604/#comment151430> throwable, not exception in the log msg - Yan Fang On Aug. 19, 2015, 8:14 a.m., Aleksandar Bircakovic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37604/ > ----------------------------------------------------------- > > (Updated Aug. 19, 2015, 8:14 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Added a catch for Throwables in Samza container. Catching Throwables can > cause problems in specific situations so I also added a partial function > 'safely' that should take care of that specific situations. > > > Diffs > ----- > > samza-core/src/main/scala/org/apache/samza/container/SamzaContainer.scala > 85b012b > > Diff: https://reviews.apache.org/r/37604/diff/ > > > Testing > ------- > > > Thanks, > > Aleksandar Bircakovic > >
