----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38049/#review99189 -----------------------------------------------------------
samza-autoscaling/src/main/java/org/apache/samza/autoscaling/deployer/ConfigManager.java (line 157) <https://reviews.apache.org/r/38049/#comment156100> since this is from the http.close(), just try/catch the httpclient.close(). also, not use the printStackTrace(), use log.error(message, e) - Yan Fang On Sept. 2, 2015, 11:45 a.m., Aleksandar Bircakovic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38049/ > ----------------------------------------------------------- > > (Updated Sept. 2, 2015, 11:45 a.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Replaced deprecated method call and suppressed some warnings. > > > Diffs > ----- > > samza-api/src/main/java/org/apache/samza/system/SystemAdmin.java bc926c5 > > samza-autoscaling/src/main/java/org/apache/samza/autoscaling/deployer/ConfigManager.java > 7089796 > > samza-autoscaling/src/main/java/org/apache/samza/autoscaling/utils/YarnUtil.java > b2d37a7 > samza-core/src/main/java/org/apache/samza/storage/StorageRecovery.java > c564964 > > samza-core/src/test/java/org/apache/samza/coordinator/stream/TestCoordinatorStreamWriter.java > 4eaaec2 > > samza-log4j/src/main/java/org/apache/samza/logging/log4j/serializers/LoggingEventJsonSerde.java > a18d8e0 > > Diff: https://reviews.apache.org/r/38049/diff/ > > > Testing > ------- > > > Thanks, > > Aleksandar Bircakovic > >
