----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38485/ -----------------------------------------------------------
Review request for samza. Repository: samza Description ------- Fixed patch: https://reviews.apache.org/r/35053/ In Meter getMeanRate return numberOfChanges / upTime. We don't have support for oneMinuteRate, fiveMinuteRate nor fifteenMinuteRate - for that we would need to import dropwizards EWMA class. If it's ok to import it will do so. Diffs ----- samza-api/src/main/java/org/apache/samza/metrics/Histogram.java PRE-CREATION samza-api/src/main/java/org/apache/samza/metrics/Meter.java PRE-CREATION samza-api/src/main/java/org/apache/samza/metrics/MetricsRegistry.java 5a00d01 samza-api/src/main/java/org/apache/samza/metrics/MetricsVisitor.java 75abfe7 samza-api/src/main/java/org/apache/samza/metrics/ReadableMetricsRegistryListener.java 739d68f samza-api/src/main/java/org/apache/samza/util/NoOpMetricsRegistry.java 3df855c samza-core/src/main/scala/org/apache/samza/metrics/MetricsRegistryMap.scala 40ffee2 samza-core/src/main/scala/org/apache/samza/metrics/reporter/JmxReporter.scala e966102 samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala fb438a4 samza-yarn/src/main/scala/org/apache/samza/webapp/ApplicationMasterRestServlet.scala 09f4dc3 Diff: https://reviews.apache.org/r/38485/diff/ Testing ------- Thanks, Aleksandar Pejakovic
