----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39130/#review102207 -----------------------------------------------------------
Ship it! +1. LGTM. Thanks! - Yi Pan (Data Infrastructure) On Oct. 8, 2015, 12:52 p.m., Aleksandar Bircakovic wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39130/ > ----------------------------------------------------------- > > (Updated Oct. 8, 2015, 12:52 p.m.) > > > Review request for samza. > > > Repository: samza > > > Description > ------- > > Specified return types for methods in KafkaSystemFactory. > > > Diffs > ----- > > > samza-kafka/src/main/scala/org/apache/samza/system/kafka/KafkaSystemFactory.scala > d84bf06 > > Diff: https://reviews.apache.org/r/39130/diff/ > > > Testing > ------- > > ./gradlew clean build > > > Thanks, > > Aleksandar Bircakovic > >
